Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heimdal: update to 7.8.0 #63

Merged
merged 3 commits into from
Nov 18, 2022
Merged

heimdal: update to 7.8.0 #63

merged 3 commits into from
Nov 18, 2022

Conversation

dscho
Copy link
Member

@dscho dscho commented Nov 16, 2022

dscho and others added 2 commits November 17, 2022 00:13
The URL currently works, but has a version hardcoded in it that should
not be hardcoded.

Signed-off-by: Johannes Schindelin <[email protected]>
Signed-off-by: Git for Windows automation <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
@dscho dscho temporarily deployed to build-pacman-packages November 17, 2022 13:53 Inactive
@dscho dscho marked this pull request as ready for review November 17, 2022 13:54
@dscho dscho self-assigned this Nov 17, 2022
@dscho dscho temporarily deployed to build-pacman-packages November 17, 2022 18:24 Inactive
@dscho
Copy link
Member Author

dscho commented Nov 17, 2022

dscho deployed to build-pacman-packages 4 hours ago

Let's see what will happen when I deploy the x86_64 build...

@dscho
Copy link
Member Author

dscho commented Nov 17, 2022

dscho deployed to build-pacman-packages 4 hours ago

Let's see what will happen when I deploy the x86_64 build...

As I thought. It's now marked as "Inactive".

I guess the standard model of deployments via workflows is that you first build all your artifacts, then deploy them all in another workflow run.

The problem with that model is that the mere act of using an environment is already considered as constituting a deployment, and environments are the only way to guard secrets behind manual gates, which is something I want to do with that package signing.

And it does not seem as if you can sign Pacman packages after building them, only while building them (the --sign option of makepkg seems to be the only way to sign them, the --sign option of repo-add does not sign the packages, it only signs the package database, i.e. the index of available packages).

This poses a problem: The only deployment model available to us appears to be incompatible with Pacman's package building/signing process.

@dscho
Copy link
Member Author

dscho commented Nov 17, 2022

And it does not seem as if you can sign Pacman packages after building them, only while building them (the --sign option of makepkg seems to be the only way to sign them, the --sign option of repo-add does not sign the packages, it only signs the package database, i.e. the index of available packages).

Hmm. It looks like I was wrong on that one. Judging by this code and this code, all makepkg --sign does is to call:

	gpg --detach-sign --use-agent "${SIGNWITHKEY[@]}" --no-armor "$filename" &>/dev/null || ret=$?

So I guess that this part of pacman-helper.sh quick_add is good enough and we can adjust the deployment processes of Git for Windows to adhere to the way GitHub workflows requires to function.

@dscho
Copy link
Member Author

dscho commented Nov 17, 2022

Having said that, the code-signing of the executables inside the Pacman packages is still something that needs to be done during the build. I am currently not sure how to deal with that issue.

@dscho
Copy link
Member Author

dscho commented Nov 18, 2022

The deployments worked, and I will have to think more about approaches how to move them completely to GitHub workflows. But I can do that elsewhere, no need to "hold this PR hostage", i.e. I will merge it.

@dscho dscho merged commit 0db7510 into main Nov 18, 2022
@dscho dscho deleted the heimdal-7.8.0 branch November 18, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New heimdal version] Heimdal 7.8
1 participant