Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git gui is launched in foreground #172

Closed
gix opened this issue May 29, 2015 · 3 comments
Closed

git gui is launched in foreground #172

gix opened this issue May 29, 2015 · 3 comments

Comments

@gix
Copy link

gix commented May 29, 2015

Executing "git gui" in a cmd.exe shell launches it in the foreground and blocks the shell until the gui is closed. This was not the case with msysgit 1.9.5 and earlier where it was launched in the background. (I found a very old feature request for background launching from 2008 so it seems this wasn't always the case).

@dscho
Copy link
Member

dscho commented May 29, 2015

I guess that we need to re-introduce this behavior, indeed. I actually found it nicer for scripting, but you are correct that it would be a regression.

It is hopefully as easy as dscho/git@git-for-windows:master...git-gui-wrapper, but I have no opportunity to test this for a week or so. Maybe you want to give it a try (this wiki page will come in handy)?

@gix
Copy link
Author

gix commented May 30, 2015

It took me a while to figure out where the cmd-wrappers are built. As just building an installer or portable archive as described in the wiki pulls them from the sdk-installation without updating, and running the packaging scripts in MINGW-packages/mingw-w64-git pulls a tagged version from your github repo. Is there a way to build/test these wrappers standalone? I hacked around it by changing the pull-url to the local file system.

Anyway, the branch checking for git-gui is the wrong one (the git-gui.exe has Windows subsystem and doesn't block). This patch works for me: gix/git@git-for-windows:master...git-gui-wrapper

@dscho
Copy link
Member

dscho commented Jun 9, 2015

@gix I tried to improve the documentation a bit (since the wrappers are built as part of the MinGW Git package, I added the new section to the wiki page about package management). Feel free to improve it more, it's a wiki.

@dscho dscho closed this as completed in 3bd1361 Jun 9, 2015
dscho pushed a commit to dscho/git that referenced this issue Jun 10, 2015
This fixes git-for-windows#172.

Signed-off-by: Nico Rieck <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit to dscho/git that referenced this issue Jun 17, 2015
This fixes git-for-windows#172.

Signed-off-by: Nico Rieck <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit that referenced this issue Jun 25, 2015
This fixes #172.

Signed-off-by: Nico Rieck <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit to dscho/git that referenced this issue Jul 18, 2015
This fixes git-for-windows#172.

Signed-off-by: Nico Rieck <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit to dscho/git that referenced this issue Jul 28, 2015
This fixes git-for-windows#172.

Signed-off-by: Nico Rieck <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit to dscho/git that referenced this issue Aug 30, 2015
This fixes git-for-windows#172.

Signed-off-by: Nico Rieck <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit that referenced this issue Sep 10, 2015
This fixes #172.

Signed-off-by: Nico Rieck <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit to dscho/git that referenced this issue Sep 18, 2015
This fixes git-for-windows#172.

Signed-off-by: Nico Rieck <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit to dscho/git that referenced this issue Sep 29, 2015
This fixes git-for-windows#172.

Signed-off-by: Nico Rieck <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit that referenced this issue Oct 5, 2015
This fixes #172.

Signed-off-by: Nico Rieck <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit to dscho/git that referenced this issue Oct 18, 2015
This fixes git-for-windows#172.

Signed-off-by: Nico Rieck <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit to dscho/git that referenced this issue Nov 7, 2015
This fixes git-for-windows#172.

Signed-off-by: Nico Rieck <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit that referenced this issue Dec 11, 2015
This fixes #172.

Signed-off-by: Nico Rieck <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit that referenced this issue Jan 5, 2016
This fixes #172.

Signed-off-by: Nico Rieck <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit to dscho/git that referenced this issue Jan 12, 2016
This fixes git-for-windows#172.

Signed-off-by: Nico Rieck <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit to dscho/git that referenced this issue Jan 14, 2016
This fixes git-for-windows#172.

Signed-off-by: Nico Rieck <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit to dscho/git that referenced this issue Jan 15, 2016
This fixes git-for-windows#172.

Signed-off-by: Nico Rieck <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit that referenced this issue Aug 13, 2016
This fixes #172.

Signed-off-by: Nico Rieck <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit that referenced this issue Aug 13, 2016
This fixes #172.

Signed-off-by: Nico Rieck <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit that referenced this issue Aug 13, 2016
This fixes #172.

Signed-off-by: Nico Rieck <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit that referenced this issue Aug 15, 2016
This fixes #172.

Signed-off-by: Nico Rieck <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit that referenced this issue Aug 15, 2016
This fixes #172.

Signed-off-by: Nico Rieck <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit that referenced this issue Aug 15, 2016
This fixes #172.

Signed-off-by: Nico Rieck <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit that referenced this issue Aug 15, 2016
This fixes #172.

Signed-off-by: Nico Rieck <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit that referenced this issue Aug 20, 2016
This fixes #172.

Signed-off-by: Nico Rieck <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit that referenced this issue Aug 20, 2016
This fixes #172.

Signed-off-by: Nico Rieck <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit that referenced this issue Aug 22, 2016
This fixes #172.

Signed-off-by: Nico Rieck <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit that referenced this issue Aug 22, 2016
This fixes #172.

Signed-off-by: Nico Rieck <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit that referenced this issue Aug 22, 2016
This fixes #172.

Signed-off-by: Nico Rieck <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit that referenced this issue Aug 25, 2016
This fixes #172.

Signed-off-by: Nico Rieck <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit that referenced this issue Aug 25, 2016
This fixes #172.

Signed-off-by: Nico Rieck <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit that referenced this issue Aug 25, 2016
This fixes #172.

Signed-off-by: Nico Rieck <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit that referenced this issue Aug 26, 2016
This fixes #172.

Signed-off-by: Nico Rieck <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit that referenced this issue Aug 26, 2016
This fixes #172.

Signed-off-by: Nico Rieck <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit that referenced this issue Aug 27, 2016
This fixes #172.

Signed-off-by: Nico Rieck <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho pushed a commit that referenced this issue Aug 28, 2016
This fixes #172.

Signed-off-by: Nico Rieck <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants