-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup moves git to the end of PATH #1990
Comments
How did this end up in the PATH? It should not be there. Besides, Back to your question: you would like Git to remember the position in the That is technically challenging, as we uninstall previous versions fully during an upgrade, i.e. the Quite honestly, I am not sure how to address this problem. Ideas? |
I added that manually for reasons unrelated to git. However it contains |
You could pass a command line parameter to the uninstaller and then read its value in Or you could take a snapshot of |
That assumes that the installer will always add the same entry to But that is not true: when the user chooses the default options, In order to address this feature request correctly, we have to handle this scenario. I don't want to end up with a hack that causes more trouble than it solves. |
This is the old topic of an git upgrade installer, where the git
uninstaller needs to be told to keep settings intact. Additionally I have
the feeling git installer should not touch the PATH variable if wants to
add its path and it's already there.
Best regards, Mike
…On Tue, Dec 18, 2018, 1:48 PM Johannes Schindelin ***@***.***> wrote:
You could pass a command line parameter to the uninstaller
<https://github.com/git-for-windows/build-extra/blob/b3e79252af5be8d7df15187692439bd97bfb7d9f/installer/install.iss#L1980>
and then read its value <https://stackoverflow.com/a/35096481/99237> in
CurUninstallStepChanged
<https://github.com/git-for-windows/build-extra/blob/b3e79252af5be8d7df15187692439bd97bfb7d9f/installer/install.iss#L2800>
.
Or you could take a snapshot of PATH before the uninstaller runs.
That assumes that the installer will always add the same entry to PATH.
But that is not true: when the user chooses the default options, <Git>\cmd
is added. When the user chooses the "all Unix tools" option in an upgrade,
the installer wants to add <Git>\mingw64\bin and <Git>\usr\bin instead.
In order to address this feature request correctly, we *have* to handle
this scenario. I don't want to end up with a hack that causes more trouble
than it solves.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1990 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHJ-yIVA6Ldkep9KutFEuWNuBplLQbyaks5u6Th8gaJpZM4ZYBn3>
.
|
On Thu, 20 Dec 2018, Mike Friedrich wrote:
This is the old topic of an git upgrade installer, where the git
uninstaller needs to be told to keep settings intact. Additionally I have
the feeling git installer should not touch the PATH variable if wants to
add its path and it's already there.
The possible options (in particular *after* learning what InnoSetup allows us to do) would be splendid argument to fight over, maybe even an epic one, or even a fierce flame war.
Alas, fierce flame wars, as much fun as they might ever have been, have yet to fix even a single thing.
|
@the-ress this sounds like your best option. Are you still interested in this change? If so, I encourage you to
|
This comment has been minimized.
This comment has been minimized.
@the-ress so... do you want this or not? I think I laid out pretty clearly how you can get this feature, and there is not really a whole lot of effort required from your side to complete this project. |
voting for reopen. would still love to see this bug fixed. i is quite annoying that after each update of git my system is broken because of git paths moved to the end of the variable. |
@c33s I would also love to see this bug fixed. But I need help for that. |
Setup
defaults?
to the issue you're seeing?
My
PATH
includesc:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE\CommonExtensions\Microsoft\TeamFoundation\Team Explorer
(to runtf.exe
).Details
CMD, PowerShell, Total Commander
Minimal, Complete, and Verifiable example
this will help us understand the issue.
git-for-windows
C:\Program Files\Git\cmd
up in thePATH
environment variablegit-for-windows
to a newer versionC:\Program Files\Git\cmd
should stay where I moved it.C:\Program Files\Git\cmd
is moved to the end of the list.This breaks running
git
from Total Commander because it opens the Git folder inc:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE\CommonExtensions\Microsoft\TeamFoundation\Team Explorer
instead.The text was updated successfully, but these errors were encountered: