Take 2: ci(mingw): speed up, by disabling the chain lint #1888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just a test balloon, to see how much it costs us. The main cost seems to be the subshell `(exit 117)`, which is expensive in the MSYS2 Bash due to the way `fork()` is emulated. Signed-off-by: Johannes Schindelin <[email protected]>
The main aim of this here patch is to allow quicker turnaround times testing several things to accelerate the test suite on Windows. Let's not bother with non-Windows phases for now, then. Signed-off-by: Johannes Schindelin <[email protected]>
We really need to be able to find the test helpers... Really. This change was forgotten when we moved the test helpers into t/helper/ Signed-off-by: Johannes Schindelin <[email protected]>
dscho
force-pushed
the
accelerate-test-suite
branch
from
5290c23
to
93de1d5
Compare
For the same reason, we need to handle test-tool.exe the same way. Signed-off-by: Johannes Schindelin <[email protected]>
This is just a test balloon, to see how much it costs us. The main cost seems to be the shell that spawns just another .exe, which is expensive in the MSYS2 Bash due to the way `fork()` is emulated. Signed-off-by: Johannes Schindelin <[email protected]>
When building Git with RUNTIME_PREFIX and starting a test helper from t/helper/, it fails to detect the system prefix correctly. This is the reason that the warning RUNTIME_PREFIX requested, but prefix computation failed. [...] to be printed. In t0061, we did not expect that to happen, and it actually did not happen in the normal case, because bin-wrappers/test-tool specifically sets GIT_TEXTDOMAINDIR (and as a consequence, nothing in test-tool wants to know about the runtime prefix). However, with --with-dashes, bin-wrappers/test-tool is no longer called, but t/helper/test-tool is called directly. So let's just ignore the RUNTIME_PREFIX warning. Signed-off-by: Johannes Schindelin <[email protected]>
This speeds up the tests by a bit on Windows, where running Unix shell scripts (and spawning processes) is not exactly a cheap operation. Signed-off-by: Johannes Schindelin <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
dscho
force-pushed
the
accelerate-test-suite
branch
from
7b0d38b
to
4e38cef
Compare
|
This experiment turned out to be useful and has been integrated into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a test balloon, to see how much it costs us. The main cost
seems to be the subshell
(exit 117), which is expensive in the MSYS2Bash due to the way
fork()is emulated.