Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support: select two commits for diff #781

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

chargenius
Copy link
Contributor

No description provided.

@YarikArsenkinDrest
Copy link

Thank you for a PR! Do you have a screenshot to see how it would look like?

@lucasderraugh
Copy link
Collaborator

Yes, please leave a description of the feature and a picture/gif/video of what has changed. Ultimately understanding what this contribution is without looking at the code is ideal.

@chargenius
Copy link
Contributor Author

chargenius commented Dec 6, 2021

截屏2021-12-06 下午2 53 43

Hold command key to select two commits, and press 'I' to show diff between these commits.

@YarikArsenkinDrest
Copy link

@lucasderraugh Could you have a look at this? Should be an awesome feature!

@lucasderraugh
Copy link
Collaborator

I will test it out this week. Need to move 1.3.1 to stable release.

@lucasderraugh lucasderraugh merged commit 9ce3656 into git-up:master Mar 23, 2022
@lucasderraugh
Copy link
Collaborator

I apologize for the long delay. Thank you @chargenius for implementing! I'll try to wrap this and a fix for the segmented control width into a release soon.

@stigkj
Copy link

stigkj commented Jun 10, 2022

Sorry for being a little late bringing this up: the help text is not completely correct after this change.

@lucasderraugh
Copy link
Collaborator

@stigkj What do you mean by that?

@stigkj
Copy link

stigkj commented Jun 10, 2022

The help text shown on top of the window the first time you use a feature says that you can diff a selected commit against HEAD. I.e. it should be changed to say that it is possible to select 2 commits and diff them too. Or maybe have another help text when 2 commits are selected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants