Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show sync github issue button to bounty owner #4870

Closed
thelostone-mc opened this issue Jul 25, 2019 · 15 comments
Closed

feat: show sync github issue button to bounty owner #4870

thelostone-mc opened this issue Jul 25, 2019 · 15 comments
Labels
Gitcoin Bounties Gitcoin Bounties

Comments

@thelostone-mc
Copy link
Member

thelostone-mc commented Jul 25, 2019

Description

When funder creates an issue, we sync the issue with GitHub to populate details. Once an issue has been created successfully, we've got a cron which pulls data and syncs every 24 hours to ensure all updates made to GitHub issue are synced

Issue

Many a time, after creating an issue -> the funder decides to update the description but this gets reflected on the Gitcoin issue only when the cronjob runs the mgmt command.
This can be frustrating to the funder especially if a change needs to be ported asap.

Solution

Introduce a button Sync Issue on the bounty detail page which gets rendered only if you are the owner of the issue / the admin.
The funder/admin would be able to click on this and this would pull the latest and update the DB thus allowing an immediate sync

The button is to be added next to the other action buttons aka the black rectangle in the below screenshot

Screenshot 2019-07-25 at 4 19 28 PM

NOTE

Reported on community slack a couple of time !

@thelostone-mc thelostone-mc changed the title feat: feat: show sync github issue button to bounty owner Jul 25, 2019
@thelostone-mc thelostone-mc added the Gitcoin Bounties Gitcoin Bounties label Jul 25, 2019
@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.4 ETH (88.48 USD @ $221.21/ETH) attached to it.

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Workers have applied to start work.

These users each claimed they can complete the work by 12 months from now.
Please review their action plans below:

1) acolytec3 has applied to start work (Funders only: approve worker | reject worker).

  1. Add new button placement as pictured.
  2. Connect up to back end dashboard utility methods that sync a bounty in the DB.

Is there any value in just having the sync run the sync_geth command and update all recent bounties or is that too much overhead?

Learn more on the Gitcoin Issue Details page.

@thelostone-mc
Copy link
Member Author

@acolytec3 nope just for that specific bounty ! Every bounty would be an overhead that may mess things up !

@acolytec3
Copy link
Contributor

@thelostone-mc Sorry but I'm going to pull out of this one. I can't get my local environment working for some reason and I've been banging my head on it for a while. Will let someone else take a shot at this one in the meanwhile.

@thelostone-mc
Copy link
Member Author

Sure thing ! Thanks for the update mate ^_^

@gitcoinbot
Copy link
Member

gitcoinbot commented Jul 29, 2019

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 11 months, 3 weeks from now.
Please review their action plans below:

1) pierrickgt has been approved to start work.

In order to complete this issue, I'll add the Sync issue button to the app/assets/v2/js/pages/bounty_details.js file and will make sure to only display it if the user is the funder of the issue or an admin.
I'll also use the code from the fund form in order to sync the Github issue.
2) acolytec3 has been approved to start work.

Finally fixed my local dev environment issues. If this is still open:

  1. Add the Sync Bounty button
  2. Wire up a new route in urls.py that calls the sync_web3 dashboard utils methods to resync the bounty between Web3 and the DB.
    3) acolytec3 has been approved to start work.

Finally fixed my local dev environment issues. If this is still open:

  1. Add the Sync Bounty button
  2. Wire up a new route in urls.py that calls the sync_web3 dashboard utils methods to resync the bounty between Web3 and the DB.

Learn more on the Gitcoin Issue Details page.

acolytec3 added a commit to acolytec3/web that referenced this issue Jul 30, 2019
@PierrickGT
Copy link
Contributor

I've completed the bounty from this issue, here is the PR: #4899
I will submit my work once my PR is reviewed.

@acolytec3
Copy link
Contributor

acolytec3 commented Jul 30, 2019

Not trying to be nitpicky here but who is approved to work on this bounty? The bot says I was approved and I'd already started my PR (which is mostly done) when I noticed the other one submitted by @PierrickGT that's already been approved by @danlipert and @octavioamu. If his approach is preferred, that's fine but would like confirmation.

@PierrickGT
Copy link
Contributor

Not trying to be nitpicky here but who is approved to work on this bounty? The bot says I was approved and I'd already started my PR (which is mostly done) when I noticed the other one submitted by @PierrickGT that's already been approved by @danlipert and @octavioamu. If his approach is preferred, that's fine but would like confirmation.

Hi,
Looking at your previous message, I thought you stopped working on this issue and that's why I've decided to open a PR.
Sorry for the misunderstanding.

@acolytec3
Copy link
Contributor

@PierrickGT - not a big deal, just want direction from the core devs before I do anything else. It's been a fruitful learning exercise for me if nothing else.

@thelostone-mc, @danlipert, @octavioamu, who gets this one?

@thelostone-mc
Copy link
Member Author

thelostone-mc commented Jul 31, 2019

@acolytec3 So here's what happened

@PierrickGT reached out to me after you let me know you had env issues ( thanks for that 🙌 )
He told me how he was gonna tackle and this was the bit of conversation where I approved him

thelostone-mc [Gitcoin Core]  [1 day ago]
sure do apply for the bounty if you decide to take it up :raised_hands:


Pierrick  [1 day ago]
I’ll take a look at the code first :slightly_smiling_face:

Pierrick  [1 day ago]
I’ve applied for the issue :slightly_smiling_face:

thelostone-mc [Gitcoin Core]  [1 day ago]
And approved ^_^

I'm not sure why the approve wasn't reflected.
I apologize for the confusion.
I should have clicked on stop work for you before approving @PierrickGT.
I assumed you had clicked stop work when you told me. My bad

Would it be alright if we went ahead with PR raised by @PierrickGT ?

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 0.4 ETH (84.86 USD @ $212.14/ETH) has been submitted by:

  1. @pierrickgt

@thelostone-mc please take a look at the submitted work:


@acolytec3
Copy link
Contributor

Yeah, not a big deal. I did hit the stop work button and then reapplied and got a notification from the system saying I was approved again which is why I started. I'll close my PR.

That said, y'all should look at that pull-github job again. I was looking at it as a model for my PR and It didn't look like it touched the issue title or description fields at all.

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 0.4 ETH (89.95 USD @ $224.88/ETH) attached to this issue has been approved & issued to @PierrickGT.

@thelostone-mc
Copy link
Member Author

Thanks @PierrickGT ^_^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gitcoin Bounties Gitcoin Bounties
Projects
None yet
Development

No branches or pull requests

4 participants