Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PWA support to the-one-api.dev #15

Closed
gitfrosh opened this issue Oct 2, 2020 · 3 comments · Fixed by #17
Closed

Add PWA support to the-one-api.dev #15

gitfrosh opened this issue Oct 2, 2020 · 3 comments · Fixed by #17
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@gitfrosh
Copy link
Owner

gitfrosh commented Oct 2, 2020

The The one API documentation website (https://the-one-api.dev) is not yet PWA ready.

Any help is appreciated! 🚀

@gitfrosh gitfrosh added enhancement New feature or request good first issue Good for newcomers labels Oct 2, 2020
@vanshajtyagi
Copy link

vanshajtyagi commented Oct 4, 2020

Hi, I would like to help but could please explain to me what all I have to do .
Like You want to make a manifest file for the one api.dev?
{ "name": "The One API", "theme_color": "#2196f3", "background_color": "#2196f3", "display": "browser", "scope": "/", "start_url": "/https://the-one-api.dev/" }
Like this you want !!

@gitfrosh
Copy link
Owner Author

gitfrosh commented Oct 5, 2020

There are some (more) requirements, that would mark the-one.api.dev as a PWA, one of them is adding a manifest. The Chrome extension Lighthouse (https://developers.google.com/web/ilt/pwa/lighthouse-pwa-analysis-tool) is a great tool to check if all requirements are fulfilled. If you feel confident, you may add a pull request to this issue. Thanks!

@gabrielclaudino
Copy link
Contributor

Hello, I can help with this issue 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants