Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PWA support #17

Merged
merged 2 commits into from
Oct 12, 2020
Merged

Add PWA support #17

merged 2 commits into from
Oct 12, 2020

Conversation

gabrielclaudino
Copy link
Contributor

Hello. I add the PWA support, and I believe it closes #15 issue.

Description

In order to created the manifest.json file I had to make some decisions:

  • Logo creation: I didn't find any logo in the project, so I created a very simple one just with the name of the app using a font based on the film (Ringbearer);
  • The theme color is the one used in the app header;
  • The description was based on what was written on the website;

These were just decisions I made to build the file and it can be changed as you wish.

Other than that, the changes were simple, I added the icons to the public folder, created some tags in the HTML header, registered the service worker, and took the opportunity to correct an internal hyperlink problem that I found on Documentation.jsx;

@gitfrosh
Copy link
Owner

Hi @gabrielclaudino, thanks for this contribution! 👍🏻 It's so cool you took the time to create and add the icons!
I'll merge your pull request and the changes will go to production with the next release.
Cheers 🚀

@gitfrosh gitfrosh merged commit 99579eb into gitfrosh:release Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PWA support to the-one-api.dev
2 participants