Fix Denethor II quote character attribution #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While playing around with the API, I noticed that I couldn't get any quotes back for [Denethor II](https://lotr.fandom.com/wiki/Denethor_II). (Denethor II is the character we know from the films and books) Upon inspecting the DB, I see that all of Denethor II's quotes are actually attributed to Denethor I, which is incorrect. Therefore, I've updated the CSV. Specifically, I've simply done a find-and-replace to replace `5cd99d4bde30eff6ebccfca1` (Denethor I) with `5cd99d4bde30eff6ebccfc9a` (Denethor II).
|
Good catch, looks OK to me. :) |
MateuszKikmunter
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While playing around with the API, I noticed that I couldn't get any quotes back for Denethor II. (Denethor II is the character we know from the films and books)
Upon inspecting the DB, I see that all of Denethor II's quotes are actually attributed to Denethor I, which is incorrect. Therefore, I've updated the CSV.
Specifically, I've simply done a find-and-replace to replace
5cd99d4bde30eff6ebccfca1(Denethor I) with5cd99d4bde30eff6ebccfc9a(Denethor II).