Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation examples for filtering expressions #21

Merged
merged 2 commits into from
Oct 27, 2020

Conversation

alexgQQ
Copy link

@alexgQQ alexgQQ commented Oct 24, 2020

Hello again 👋

Glad you found use from the filtering functionality in my previous PR . This just adds some example uses for the filtering in the docs application you have. Let me know your thoughts when you get a chance.

I'd be curious on your thoughts of some nested filtering functionality too. With this current setup, you can filter on direct values for the requested data model. A neat feature would be something like /quotes?character_name='Gandalf'. It would take some hacking, we'd need to figure some functions to cast it (https://github.com/leodinas-hao/mongoose-query-parser#add-custom-casting-functions) but if it would be useful we can give it a shot

Happy #hacktoberfest 🎉

@gitfrosh
Copy link
Owner

Hi there,
thanks again for your contribution, really great! I added some minor changes and will merge your PR.
Let's definitely have a look into nested filtering functionality! Feel free to open a PR whenever you like.
Cheers 🍾

@gitfrosh gitfrosh merged commit 97992c1 into gitfrosh:release Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants