Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #83

Merged
merged 2 commits into from
Dec 2, 2022
Merged

Update README.md #83

merged 2 commits into from
Dec 2, 2022

Conversation

Os51
Copy link
Contributor

@Os51 Os51 commented Oct 24, 2022 •
edited
Loading

What type of PR is this?

  • Documentation Update

Description

Redesign of the LOTR-API Project Starter Page / README.md

Overview of Changes

  • Structural changes to README topics
  • Addition of badge.io shields for the repository statistics
  • Brief overview of the languages used in the source (per information obtained from developer website)
  • Addition of contributors image - embed from contrib.rocks
  • Added a Contacts section - shields added and hyperlinked to gitfrosh's Github Profile and a mailto protocol hyperlink for the email address under "Ask me anything".

Related Tickets & Documents

Thank you! Please let me know if any additions or removals need to be done.

@Os51
Update README.md
99230cb 
Readme Redesign for lotr-api repo
@EddieEldridge
Copy link
Contributor

Nice work, looks great!

@MateuszKikmunter
Copy link
Collaborator

Looks really good, thanks! 🙂

@EddieEldridge
Copy link
Contributor

image
I think it would look nicer if this text was also centered but just my opinion :)

@Os51
Copy link
Contributor Author

Os51 commented Oct 26, 2022

image I think it would look nicer if this text was also centered but just my opinion :)

That should be fine to do if preferred 😄 - would you like me to edit it?

@Os51
Update README.md
492ea07 
- Removed closing </div> tag that was not associated to an opening tag.
- Per recommendation in gitfrosh#83, centered text in introduction for programming languages used.
@Os51
Copy link
Contributor Author

Os51 commented Oct 26, 2022

I've made some changes per #83 (comment)

Top details now look like:
PR LOTRAPI_Preview

  • Additionally made some code amendments for better readability and removed an unassociated tag that I seem to have missed previously.

Thanks for the feedback and support!

MateuszKikmunter
MateuszKikmunter approved these changes Oct 26, 2022
View reviewed changes
Copy link
Collaborator

@MateuszKikmunter MateuszKikmunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good !

@EddieEldridge
Copy link
Contributor

EddieEldridge commented Oct 26, 2022 •
edited
Loading

I've made some changes per #83 (comment)

Nice work, I like it a lot :)

@gitfrosh
Copy link
Owner

Awesome, thanks for your contribution, @Os51! Your PR will be merged for the next release after #hacktoberfest is done. :)

@Os51
Copy link
Contributor Author

Os51 commented Oct 28, 2022

Awesome, thanks for your contribution, @Os51! Your PR will be merged for the next release after #hacktoberfest is done. :)

Thank you! Been a pleasure :)

@gitfrosh gitfrosh merged commit cfce663 into gitfrosh:release Dec 2, 2022
@gitfrosh gitfrosh linked an issue Dec 2, 2022 that may be closed by this pull request
Improving Github Repo starter page / README #82
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MateuszKikmunter MateuszKikmunter MateuszKikmunter approved these changes

@EddieEldridge EddieEldridge EddieEldridge approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improving Github Repo starter page / README
4 participants
@Os51 @EddieEldridge @MateuszKikmunter @gitfrosh