Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(view): commit 중복 bug fix #508

Merged
merged 1 commit into from
Dec 15, 2023
Merged

fix(view): commit 중복 bug fix #508

merged 1 commit into from
Dec 15, 2023

Conversation

inthejim
Copy link
Contributor

@inthejim inthejim commented Oct 5, 2023

Related issue

#507

Result

전:
고치기 전
후:
고친후

Discussion

서브 그래프와 순서가 반대라, 헷갈릴 수 있을 것 같습니다.

@inthejim inthejim requested review from a team as code owners October 5, 2023 09:30
@@ -13,9 +13,9 @@ const useToggleHook = (init = false): UseToggleHook => {

export const useCommitListHide = (commitNodeListInCluster: CommitNode[]) => {
const list = getSummaryCommitList(commitNodeListInCluster).reverse();
const strech = commitNodeListInCluster.slice(5, commitNodeListInCluster.length).reverse();
const strech = commitNodeListInCluster.reverse();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다섯개 단위로 접혀서 나오는 건지요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아니요, 기존의 동작과 동일하게 작동합니다!
처음에 5개가 나온 후, readmore을 누르면 전체 commit 이 나오고 hide를 누르면 5개가 보여지는 처음의 상태로 돌아갑니다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5개 단위로 접혀서 나오도록 수정해보겠습니다!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앗. 넵!

Copy link
Contributor

@ytaek ytaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제가 만든 버그 같은데, 수정해주셔서 감사합니다!! :)

Copy link
Contributor

@KyuTae98 KyuTae98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 입니다!!

Copy link
Contributor Author

@inthejim inthejim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@all-contributors please add @inthejim for code

@inthejim inthejim merged commit 872ab1a into githru:main Dec 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants