feat(vscode): #321 githru 열리기 전까지 progress 표시 #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytaek
approved these changes
Jul 20, 2024
packages/vscode/src/extension.ts
Outdated
| }, | ||
| null, | ||
| context.subscriptions | ||
| ); | ||
|
|
||
| subscriptions.push(webLoader); | ||
| myStatusBarItem.text = "$(check) githru"; |
There was a problem hiding this comment.
"githru" 스트링이 반복되니,
윗쪽에서 따로 literal 로 선언해놓고 변수만 활용해도 괜찮을 것 같습니다.
(그럴 일이 잘 없겠지만, 이름이 바뀐다거나, 혹은 version을 추후에 표시할 수도 있으니? 😸 )
const projectName = "githru;
There was a problem hiding this comment.
감사합니다! 피드백 반영하여 다시 푸쉬해두었습니다!
choisohyun
approved these changes
Jul 20, 2024
|
built-in icons를 쓰니 VSCode UI와도 잘 어울려서 좋네요! 😮😮 😮 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#321 [vscode] githru 열리기 전까지 progress 표시
Result
Work list
패널이 열리기 전 / 닫은 후
패널이 뜨는 중
패널이 뜬 후
Discussion
로딩 시 스피너 외에 패널이 뜬 후 패널이 없을 때와 구분을 위해 체크 progress를 추가 하였습니다.
Reference
[visualstuido 공식문서]
https://code.visualstudio.com/api/references/icons-in-labels
https://code.visualstudio.com/api/ux-guidelines/status-bar
https://code.visualstudio.com/api/references/vscode-api#StatusBarItem