feat(view): Primary color에 따라 File Summary 글자 색상 동적 변경 #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxxjinn
approved these changes
Jul 26, 2024
Sang-minKIM
approved these changes
Jul 26, 2024
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| .file-icicle-summary { | |||
| text { | |||
| fill: $white; | |||
| fill: var(--primary-color); | |||
| filter: invert(100) grayscale(100) contrast(100); | |||
There was a problem hiding this comment.
와.. 이런 방법이..!!
filter라는 속성이 있는 걸 처음 알았네요
진짜 좋은 방법인 것 같아요 많이 배워갑니다👍🏻
HIITMEMARIO
pushed a commit
to HIITMEMARIO/githru-vscode-ext
that referenced
this pull request
Jul 28, 2024
|
와 이 방법 너무 멋진데요!!!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#528
Result
File Summary 차트의 배경 색상이 되는
primary color가 변경될 때마다 글자 색상이 동적으로 변경됩니다.Work list
filter속성을 사용하여 배경 색상이 어두울 때는white컬러, 배경 색상이 밝을 때는black컬러로 보입니다.Discussion
색상 값을 계산하거나 SVG 필터를 씌우는 것보다 간단한 방법이라고 생각해서 이렇게 구현했는데요,
혹시 더 좋은 방법이 있다면 편하게 제안해주세요! 🙌🙌🙌