Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[view] temporal filter 차트가 잘리는 경우에도 보이도록 수정 #650

Merged
merged 2 commits into from
Aug 18, 2024

Conversation

seungineer
Copy link
Member

Related issue

#649

Result

image
  • 차트의 하단까지 잘 보이는 것을 확인할 수 있습니다.

Work list

  • 차트 영역 바깥으로 넘어가는 그래프도 보이도록 overflow: visible;속성 값을 추가했습니다.

Discussion

image
  • 임시방편으로 overflow: visible 속성을 추가하여 보이도록 하였습니다.
  • line-charts 내에서 차트가 잘리지 않고 표시되도록 추후 수정이 필요할 것 같습니다.

@seungineer seungineer added this to the v0.7.0 milestone Aug 18, 2024
@seungineer seungineer self-assigned this Aug 18, 2024
@seungineer seungineer requested review from a team as code owners August 18, 2024 06:59
@seungineer seungineer merged commit c56d2d7 into githru:main Aug 18, 2024
2 checks passed
@ytaek
Copy link
Contributor

ytaek commented Aug 18, 2024

임시방편인 내용이라면, issue에 수정해야 하는 상황을 등록해주시면 감사하겠습니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants