Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Repairing xml comments #1846

Merged
merged 6 commits into from
Aug 13, 2018
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/GitHub.Api/ILoginManager.cs
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ Task<User> LoginWithToken(
/// Logs out of GitHub server.
/// </summary>
/// <param name="hostAddress">The address of the server.</param>
/// <param name="client">An octokit client configured to access the server.</param>
Task Logout(HostAddress hostAddress, IGitHubClient client);
}
}
2 changes: 2 additions & 0 deletions src/GitHub.Api/LoginManager.cs
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,10 @@ public class LoginManager : ILoginManager
/// </summary>
/// <param name="keychain">The keychain in which to store credentials.</param>
/// <param name="twoFactorChallengeHandler">The handler for 2FA challenges.</param>
/// <param name="oauthListener">The callback listener to signal successful login.</param>
/// <param name="clientId">The application's client API ID.</param>
/// <param name="clientSecret">The application's client API secret.</param>
/// <param name="scopes">List of scopes to authenticate for</param>
/// <param name="authorizationNote">An note to store with the authorization.</param>
/// <param name="fingerprint">The machine fingerprint.</param>
public LoginManager(
Expand Down
3 changes: 2 additions & 1 deletion src/GitHub.App/Extensions/AkavacheExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -252,11 +252,12 @@ static IObservable<T> GetAndFetchLatestFromIndex<T>(this IBlobCache This,
/// <typeparam name="T"></typeparam>
/// <param name="blobCache">The cache to retrieve the object from.</param>
/// <param name="key">The key to look up the cache value with.</param>
/// <param name="item">The item to add to the database</param>
/// <param name="fetchFunc"></param>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fetch function - this is what the other params like like in the same file are documented with.

/// <param name="maxCacheDuration">
/// The maximum age of a cache object before the object is treated as
/// expired and unusable. Cache objects older than this will be treated
/// as a cache miss.
/// </param>
/// <returns></returns>
public static IObservable<T> PutAndUpdateIndex<T>(this IBlobCache blobCache,
string key,
Expand Down
1 change: 1 addition & 0 deletions src/GitHub.App/Services/PullRequestEditorService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,7 @@ public IVsTextView FindActiveView()
/// <param name="fromLines">The document we're navigating from.</param>
/// <param name="toLines">The document we're navigating to.</param>
/// <param name="line">The 0-based line we're navigating from.</param>
/// <param name="matchLinesAbove"></param>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The number of lines to match.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcansdale shouldn't the default for this parameter be MatchLinesAboveTarget instead of 0?

/// <returns>The best matching line in <see cref="toLines"/></returns>
public int FindMatchingLine(IList<string> fromLines, IList<string> toLines, int line, int matchLinesAbove = 0)
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,13 @@ public sealed class PullRequestDetailViewModel : PanePageViewModelBase, IPullReq
/// <summary>
/// Initializes a new instance of the <see cref="PullRequestDetailViewModel"/> class.
/// </summary>
/// <param name="localRepository">The local repository.</param>
/// <param name="modelService">The model service.</param>
/// <param name="pullRequestsService">The pull requests service.</param>
/// <param name="sessionManager">The pull request session manager.</param>
/// <param name="modelServiceFactory">The model service factory</param>
/// <param name="usageTracker">The usage tracker.</param>
/// <param name="teamExplorerContext">The context for tracking repo changes</param>
/// <param name="files">The view model which will display the changed files</param>
/// <param name="syncSubmodulesCommand">A command that will be run when <see cref="SyncSubmodules"/> is executed</param>
[ImportingConstructor]
public PullRequestDetailViewModel(
IPullRequestService pullRequestsService,
Expand Down Expand Up @@ -200,6 +201,7 @@ public string TargetBranchDisplayName
private set { this.RaiseAndSetIfChanged(ref targetBranchDisplayName, value); }
}

/// <summary>
/// Gets a value indicating whether the pull request branch is checked out.
/// </summary>
public bool IsCheckedOut
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public class PullRequestDirectoryNode : IPullRequestDirectoryNode
/// <summary>
/// Initializes a new instance of the <see cref="PullRequestDirectoryNode"/> class.
/// </summary>
/// <param name="path">The path to the directory, relative to the repository.</param>
/// <param name="relativePath">The path to the directory, relative to the repository.</param>
public PullRequestDirectoryNode(string relativePath)
{
DirectoryName = System.IO.Path.GetFileName(relativePath);
Expand Down
8 changes: 5 additions & 3 deletions src/GitHub.Exports.Reactive/Services/IGitClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ public interface IGitClient
/// </returns>
Task<ContentChanges> CompareWith(IRepository repository, string sha1, string sha2, string path, byte[] contents);

/// <summary>
/// Gets the value of a configuration key.
/// </summary>
/// <param name="repository">The repository.</param>
Expand Down Expand Up @@ -189,7 +190,7 @@ public interface IGitClient
/// <summary>
/// Find the merge base SHA between two commits.
/// </summary>
/// <param name="repository">The repository.</param>
/// <param name="repo">The repository.</param>
/// <param name="targetCloneUrl">The clone url of the PR target repo.</param>
/// <param name="baseSha">The PR base SHA.</param>
/// <param name="headSha">The PR head SHA.</param>
Expand All @@ -201,9 +202,10 @@ public interface IGitClient
/// <exception cref="LibGit2Sharp.NotFoundException">Thrown when the merge base can't be found.</exception>
Task<string> GetPullRequestMergeBase(IRepository repo, UriString targetCloneUrl, string baseSha, string headSha, string baseRef, int pullNumber);

/// <summary>
/// Checks whether the current head is pushed to its remote tracking branch.
/// </summary>
/// <param name="repository">The repository.</param>
/// <param name="repo">The repository.</param>
/// <returns></returns>
Task<bool> IsHeadPushed(IRepository repo);

Expand All @@ -212,7 +214,7 @@ public interface IGitClient
/// <paramref name="baseBranch"/> and <paramref name="compareBranch"/> and returns their
/// commit messages.
/// </summary>
/// <param name="repository">The repository.</param>
/// <param name="repo">The repository.</param>
/// <param name="baseBranch">The base branch to find a merge base with.</param>
/// <param name="compareBranch">The compare branch to find a merge base with.</param>
/// <param name="maxCommits">The maximum number of commits to return.</param>
Expand Down
2 changes: 2 additions & 0 deletions src/GitHub.Exports.Reactive/Services/IPullRequestService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ public interface IPullRequestService
/// <param name="owner">The repository owner.</param>
/// <param name="name">The repository name.</param>
/// <param name="after">The end cursor of the previous page, or null for the first page.</param>
/// <param name="states">The pull request states to filter by</param>
/// <returns>A page of pull request item models.</returns>
Task<Page<PullRequestListItemModel>> ReadPullRequests(
HostAddress address,
Expand Down Expand Up @@ -84,6 +85,7 @@ IObservable<IPullRequestModel> CreatePullRequest(IModelService modelService,
/// Sync submodules on the current branch.
/// </summary>
/// <param name="repository">The repository.</param>
/// <param name="progress">A method that will be called with progress messages</param>
Task<bool> SyncSubmodules(ILocalRepositoryModel repository, Action<string> progress);

/// <summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ Task PostReviewComment(

/// <summary>
/// Refreshes the pull request session.
/// </summary>
/// <returns>A task which completes when the session has completed refreshing.</returns>
Task Refresh();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ namespace GitHub.Services
/// If the currently checked out branch represents a pull request then <see cref="CurrentSession"/>
/// will return an <see cref="IPullRequestSession"/> containing the details of that pull request.
/// A session for any other pull request can also be retrieved by calling
/// <see cref="GetSession(IPullRequestModel)"/>.
/// <see cref="GetSession(string, string, int)"/>.
///
/// Calling <see cref="GetLiveFile(string, ITextView, ITextBuffer)"/> will return an
/// <see cref="IPullRequestSessionFile"/> which tracks both the contents of a text buffer and the
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public interface IRepositoryCloneService
/// <param name="repositoryPath">The directory that will contain the repository directory.</param>
/// <param name="progress">
/// An object through which to report progress. This must be of type
/// <see cref="System.IProgress{Microsoft.VisualStudio.Shell.ServiceProgressData}"/>, but
/// System.IProgress&lt;Microsoft.VisualStudio.Shell.ServiceProgressData&gt;, but
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened here?

Copy link
Contributor Author

@StanleyGoldman StanleyGoldman Aug 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was an incorrect <see> tag. The "cref" value could provide a link to documentation for System.IProgress{T} or Microsoft.VisualStudio.Shell.ServiceProgressData, but there is no link to documentation for System.IProgress{Microsoft.VisualStudio.Shell.ServiceProgressData}.

/// as that type is only available in VS2017+ it is typed as <see cref="object"/> here.
/// </param>
/// <returns></returns>
Expand Down
1 change: 1 addition & 0 deletions src/GitHub.Exports.Reactive/Services/IShowDialogService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ public interface IShowDialogService
/// The value returned by the <paramref name="viewModel"/>'s
/// <see cref="IDialogContentViewModel.Done"/> observable, or null if the dialog was
/// canceled.
/// </returns>
/// <remarks>
/// The first existing connection will be used. If there is no existing connection, the
/// login dialog will be shown first.
Expand Down
2 changes: 1 addition & 1 deletion src/GitHub.Exports/Factories/IViewViewModelFactory.cs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public interface IViewViewModelFactory
/// <summary>
/// Creates a view model based on the specified interface type.
/// </summary>
/// <typeparam name="T">The view model interface type.</typeparam>
/// <typeparam name="TViewModel">The view model interface type.</typeparam>
/// <returns>The view model.</returns>
TViewModel CreateViewModel<TViewModel>() where TViewModel : IViewModel;

Expand Down
1 change: 1 addition & 0 deletions src/GitHub.Exports/Models/ILocalRepositoryModel.cs
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ public interface ILocalRepositoryModel : IRepositoryModel, INotifyPropertyChange
/// Generates a http(s) url to the repository in the remote server, optionally
/// pointing to a specific file and specific line range in it.
/// </summary>
/// <param name="linkType">The type of repository link to create</param>
/// <param name="path">The file to generate an url to. Optional.</param>
/// <param name="startLine">A specific line, or (if specifying the <paramref name="endLine"/> as well) the start of a range</param>
/// <param name="endLine">The end of a line range on the specified file.</param>
Expand Down
6 changes: 3 additions & 3 deletions src/GitHub.Exports/Services/IGitHubContextService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,14 @@ public interface IGitHubContextService
/// <summary>
/// Convert a context to a repository URL.
/// </summary>
/// <param name="context">The context to convert.</param>
/// <param name="windowTitle">A browser window title.</param>
/// <returns>A repository URL</returns>
GitHubContext FindContextFromWindowTitle(string windowTitle);

/// <summary>
/// Find a context from a browser window title.
/// </summary>
/// <param name="windowTitle">A browser window title.</param>
/// <param name="context"></param>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The context? Not very descriptive. Do we need more info than this? @jcansdale?

/// <returns>The context or null if none can be found</returns>
Uri ToRepositoryUrl(GitHubContext context);

Expand Down Expand Up @@ -78,7 +78,7 @@ public interface IGitHubContextService
/// Team Explorer creates temporary blob files in the following format:
/// C:\Users\me\AppData\Local\Temp\TFSTemp\vctmp21996_181282.IOpenFromClipboardCommand.783ac965.cs
/// The object-ish appears immediately before the file extension and the path contains the folder "TFSTemp".
/// <remarks>
/// </remarks>
/// <param name="tempFile">The path to a possible Team Explorer temporary blob file.</param>
/// <returns>The target file's object-ish (blob SHA fragment) or null if the path isn't recognized as a Team Explorer blob file.</returns>
string FindObjectishForTFSTempFile(string tempFile);
Expand Down
5 changes: 4 additions & 1 deletion src/GitHub.Exports/Services/IGitService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ public interface IGitService
/// is null or no remote exists, this method returns null
/// </summary>
/// <param name="repository">The repository to look at for the remote.</param>
/// <param name="remote">The remote name to look for</param>
/// <returns>A <see cref="UriString"/> representing the origin or null if none found.</returns>
UriString GetUri(IRepository repository, string remote = "origin");

Expand All @@ -24,6 +25,7 @@ public interface IGitService
/// walks up the parent directories until it either finds a repository, or reaches the root disk.
/// </remarks>
/// <param name="path">The path to start probing</param>
/// <param name="remote">The remote name to look for</param>
/// <returns>A <see cref="UriString"/> representing the origin or null if none found.</returns>
UriString GetUri(string path, string remote = "origin");

Expand All @@ -42,7 +44,8 @@ public interface IGitService
/// <summary>
/// Returns a <see cref="UriString"/> representing the uri of a remote.
/// </summary>
/// <param name="repo"></param>
/// <param name="repo">The repository to look at for the remote.</param>
/// <param name="remote">The remote name to look for</param>
/// <returns></returns>
UriString GetRemoteUri(IRepository repo, string remote = "origin");

Expand Down
4 changes: 3 additions & 1 deletion src/GitHub.Exports/Services/IVSGitServices.cs
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,11 @@ public interface IVSGitServices
/// <param name="recurseSubmodules">Whether to recursively clone submodules.</param>
/// <param name="progress">
/// An object through which to report progress. This must be of type
/// <see cref="System.IProgress{Microsoft.VisualStudio.Shell.ServiceProgressData}"/>, but
/// System.IProgress&lt;Microsoft.VisualStudio.Shell.ServiceProgressData&gt;, but
/// as that type is only available in VS2017+ it is typed as <see cref="object"/> here.
/// </param>
/// <seealso cref="System.IProgress{T}"/>
/// <seealso cref="Microsoft.VisualStudio.Shell.ServiceProgressData"/>
Task Clone(
string cloneUrl,
string clonePath,
Expand Down
2 changes: 1 addition & 1 deletion src/GitHub.Exports/Services/IVSServices.cs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public interface IVSServices
/// Our workaround is to create, open and delete a solution in the repo directory.
/// This triggers an event that causes the target repo to open. ;)
/// </remarks>
/// <param name="repoPath">The path to the repository to open</param>
/// <param name="directory">The path to the repository to open</param>
/// <returns>True if a transient solution was successfully created in target directory (which should trigger opening of repository).</returns>
bool TryOpenRepository(string directory);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ abstract class InlineCommentNavigationCommand : VsCommand<InlineCommentNavigatio
/// <summary>
/// Initializes a new instance of the <see cref="InlineCommentNavigationCommand"/> class.
/// </summary>
/// <param name="serviceProvider"></param>
/// <param name="tagAggregatorFactory">The tag aggregator factory.</param>
/// <param name="peekService">The peek service.</param>
/// <param name="commandSet">The GUID of the group the command belongs to.</param>
Expand Down Expand Up @@ -74,7 +75,7 @@ protected int GetCursorPoint(ITextView textView, InlineCommentNavigationParams p
/// <summary>
/// Gets the text buffer position for the specified line.
/// </summary>
/// <param name="parameter">The parameters.</param>
/// <param name="textView">The text view containing the buffer</param>
/// <param name="lineNumber">The 0-based line number.</param>
/// <returns></returns>
protected int GetCursorPoint(ITextView textView, int lineNumber)
Expand Down Expand Up @@ -217,7 +218,10 @@ protected IReadOnlyList<ITagInfo> GetTags(IEnumerable<ITextView> textViews)
/// <summary>
/// Shows the inline comments for the specified tag in a peek view.
/// </summary>
/// <param name="tag"></param>
/// <param name="textView">The text view containing the tag</param>
/// <param name="tag">The inline comment tag</param>
/// <param name="parameter">The navigation parameter detailing a search from the specified tag</param>
/// <param name="allTextViews">The full list of text views</param>
protected void ShowPeekComments(
InlineCommentNavigationParams parameter,
ITextView textView,
Expand Down
4 changes: 1 addition & 3 deletions src/GitHub.InlineReviews/Models/InlineCommentThreadModel.cs
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,10 @@ class InlineCommentThreadModel : ReactiveObject, IInlineCommentThreadModel
/// </summary>
/// <param name="relativePath">The relative path to the file that the thread is on.</param>
/// <param name="commitSha">The SHA of the commit that the thread appears on.</param>
/// <param name="originalPosition">
/// The 1-based line number in the original diff that the thread was left on.
/// </param>
/// <param name="diffMatch">
/// The last five lines of the thread's diff hunk, in reverse order.
/// </param>
/// <param name="comments">The comments in the thread</param>
public InlineCommentThreadModel(
string relativePath,
string commitSha,
Expand Down
2 changes: 1 addition & 1 deletion src/GitHub.InlineReviews/Services/IDiffService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public interface IDiffService
/// </summary>
/// <param name="repo">The repository</param>
/// <param name="baseSha">The base commit SHA.</param>
/// <param name="headSha">The head commit SHA.</param
/// <param name="headSha">The head commit SHA.</param>
/// <param name="relativePath">The path to the file in the repository.</param>
/// <param name="contents">The byte array to compare with the base SHA.</param>
/// <returns>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ public interface IInlineCommentPeekService
/// Gets the line number for a peek session tracking point.
/// </summary>
/// <param name="session">The peek session.</param>
/// <param name="point">The peek session tracking point</param>
/// <returns>
/// A tuple containing the line number and whether the line number represents a line in the
/// left hand side of a diff view.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public class PullRequestSessionManager : ReactiveObject, IPullRequestSessionMana
/// </summary>
/// <param name="service">The PR service to use.</param>
/// <param name="sessionService">The PR session service to use.</param>
/// <param name="teamExplorerService">The team explorer service to use.</param>
/// <param name="teamExplorerContext">The team explorer context to use.</param>
[ImportingConstructor]
public PullRequestSessionManager(
IPullRequestService service,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ public PullRequestReviewCommentViewModel(
/// <param name="commentService">Comment Service</param>
/// <param name="thread">The thread that the comment is a part of.</param>
/// <param name="currentUser">The current user.</param>
/// <param name="review"></param>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The associated pull request review.

/// <param name="model">The comment model.</param>
public PullRequestReviewCommentViewModel(
IPullRequestSession session,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public static class MenuCommandServiceExtensions
/// Adds <see cref="IVsCommand"/>s or <see cref="IVsCommand{TParam}"/>s to a menu.
/// </summary>
/// <param name="service">The menu command service.</param>
/// <param name="command">The commands to add.</param>
/// <param name="commands">The commands to add.</param>
public static void AddCommands(
this IMenuCommandService service,
params IVsCommandBase[] commands)
Expand Down
Loading