-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Repairing xml comments #1846
Repairing xml comments #1846
Changes from 3 commits
2cf8ff9
72fd428
13e9fc8
18e2201
397e916
41ca8a2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -336,6 +336,7 @@ public IVsTextView FindActiveView() | |
/// <param name="fromLines">The document we're navigating from.</param> | ||
/// <param name="toLines">The document we're navigating to.</param> | ||
/// <param name="line">The 0-based line we're navigating from.</param> | ||
/// <param name="matchLinesAbove"></param> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @jcansdale shouldn't the default for this parameter be |
||
/// <returns>The best matching line in <see cref="toLines"/></returns> | ||
public int FindMatchingLine(IList<string> fromLines, IList<string> toLines, int line, int matchLinesAbove = 0) | ||
{ | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,7 +23,7 @@ public interface IRepositoryCloneService | |
/// <param name="repositoryPath">The directory that will contain the repository directory.</param> | ||
/// <param name="progress"> | ||
/// An object through which to report progress. This must be of type | ||
/// <see cref="System.IProgress{Microsoft.VisualStudio.Shell.ServiceProgressData}"/>, but | ||
/// System.IProgress<Microsoft.VisualStudio.Shell.ServiceProgressData>, but | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What happened here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It was an incorrect |
||
/// as that type is only available in VS2017+ it is typed as <see cref="object"/> here. | ||
/// </param> | ||
/// <returns></returns> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,14 +30,14 @@ public interface IGitHubContextService | |
/// <summary> | ||
/// Convert a context to a repository URL. | ||
/// </summary> | ||
/// <param name="context">The context to convert.</param> | ||
/// <param name="windowTitle">A browser window title.</param> | ||
/// <returns>A repository URL</returns> | ||
GitHubContext FindContextFromWindowTitle(string windowTitle); | ||
|
||
/// <summary> | ||
/// Find a context from a browser window title. | ||
/// </summary> | ||
/// <param name="windowTitle">A browser window title.</param> | ||
/// <param name="context"></param> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
/// <returns>The context or null if none can be found</returns> | ||
Uri ToRepositoryUrl(GitHubContext context); | ||
|
||
|
@@ -78,7 +78,7 @@ public interface IGitHubContextService | |
/// Team Explorer creates temporary blob files in the following format: | ||
/// C:\Users\me\AppData\Local\Temp\TFSTemp\vctmp21996_181282.IOpenFromClipboardCommand.783ac965.cs | ||
/// The object-ish appears immediately before the file extension and the path contains the folder "TFSTemp". | ||
/// <remarks> | ||
/// </remarks> | ||
/// <param name="tempFile">The path to a possible Team Explorer temporary blob file.</param> | ||
/// <returns>The target file's object-ish (blob SHA fragment) or null if the path isn't recognized as a Team Explorer blob file.</returns> | ||
string FindObjectishForTFSTempFile(string tempFile); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -88,6 +88,7 @@ public PullRequestReviewCommentViewModel( | |
/// <param name="commentService">Comment Service</param> | ||
/// <param name="thread">The thread that the comment is a part of.</param> | ||
/// <param name="currentUser">The current user.</param> | ||
/// <param name="review"></param> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
/// <param name="model">The comment model.</param> | ||
public PullRequestReviewCommentViewModel( | ||
IPullRequestSession session, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fetch function
- this is what the other params like like in the same file are documented with.