XML: add NODE_FOOTNOTE type strings and footnote emitters #362
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this will begin to address the issues in #341 and #316.
(Update 2023-04-17: I added
id
anddestination
attributes to these nodes based on what I saw in the html writer)I have run make test and everything passes for me. I have additionally tested this on a minimal document:
I was not sure of what type labels to give the nodes, so I named them
fnref
andfn
for the reference and the definition, respectively. If there is a more relevant precedent, then let's go for that.