Skip to content

Commit

Permalink
Catch gotcha in PR check workflow generator
Browse files Browse the repository at this point in the history
  • Loading branch information
henrymercer committed Sep 23, 2024
1 parent ac3fca3 commit 990feb5
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion pr-checks/sync.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,10 @@ def writeHeader(checkStream):
matrix = []
excludedOsesAndVersions = checkSpecification.get('excludeOsAndVersionCombination', [])
for version in checkSpecification.get('versions', defaultTestVersions):
runnerImages = ["ubuntu-latest", "macos-latest", "windows-latest"]
if version == "latest":
raise ValueError('Did not recognize "version: latest". Did you mean "version: linked"?')

runnerImages = ["ubuntu-latest", "macos-latest", "windows-latest"]
operatingSystems = checkSpecification.get('operatingSystems', ["ubuntu", "macos", "windows"])

for operatingSystem in operatingSystems:
Expand Down

0 comments on commit 990feb5

Please sign in to comment.