Handle ReserveCacheError with a nicer message

github · Nov 12, 2024 · b0c0aad · b0c0aad
1 parent 5cb4249
commit b0c0aad
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 5 deletions.
diff --git a/lib/dependency-caching.js b/lib/dependency-caching.js
diff --git a/lib/dependency-caching.js.map b/lib/dependency-caching.js.map
diff --git a/src/dependency-caching.ts b/src/dependency-caching.ts
@@ -181,10 +181,25 @@ export async function uploadDependencyCaches(config: Config, logger: Logger) {
     const key = await cacheKey(language, cacheConfig);
 
     logger.info(
-      `Uploading cache of size ${size} for ${language} with key ${key}`,
+      `Uploading cache of size ${size} for ${language} with key ${key}...`,
     );
 
-    await actionsCache.saveCache(cacheConfig.paths, key);
+    try {
+      await actionsCache.saveCache(cacheConfig.paths, key);
+    } catch (error) {
+      // `ReserveCacheError` indicates that the cache key is already in use, which means that a
+      // cache with that key already exists or is in the process of being uploaded by another
+      // workflow. We can ignore this.
+      if (error instanceof actionsCache.ReserveCacheError) {
+        logger.info(
+          `Not uploading cache for ${language}, because ${key} is already in use.`,
+        );
+        logger.debug(error.message);
+      } else {
+        // Propagate other errors upwards.
+        throw error;
+      }
+    }
   }
 }