Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add path filters to python-deps workflow #1152

Merged
merged 3 commits into from
Jul 28, 2022

Conversation

adityasharad
Copy link
Contributor

@adityasharad adityasharad commented Jul 27, 2022

No need to run this workflow on all PRs, only those that change the Python dependency installation mechanism.

Reviewer note: This will need an update to the branch protection rules, because these checks can no longer be required on all PRs.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • [N/A] Confirm the readme has been updated if necessary.
  • [N/A] Confirm the changelog has been updated if necessary.

@adityasharad adityasharad requested a review from a team as a code owner July 27, 2022 19:42
@adityasharad adityasharad marked this pull request as draft July 27, 2022 19:42
No need to run this workflow on all PRs, only those that
change the Python dependency installation mechanism.
@adityasharad adityasharad force-pushed the adityasharad/actions/python-deps-path-filters branch from 98a7225 to 0d16d70 Compare July 27, 2022 20:17
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should run this on a schedule as well (weekly?). And put in a workflow_dispatch trigger so we can run manually.

@adityasharad adityasharad marked this pull request as ready for review July 27, 2022 21:34
@adityasharad adityasharad merged commit 6c23d76 into main Jul 28, 2022
@adityasharad adityasharad deleted the adityasharad/actions/python-deps-path-filters branch July 28, 2022 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants