Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tests with old certifi dependency #1441

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

henrymercer
Copy link
Contributor

See GHSA-43fp-rhv2-5gv8. It is not possible to upgrade the Python 2 tests to use the patched certifi, as this requires Python >=3.6, so for now we're removing them.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested review from a team as code owners December 20, 2022 10:35
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine on the Action-side, assume we are waiting for @github/codeql-python to review before merge 👍

@henrymercer
Copy link
Contributor Author

We can merge with a review from either team here :)

@henrymercer henrymercer merged commit 579411f into main Dec 20, 2022
@henrymercer henrymercer deleted the henrymercer/remove-old-certifi-tests branch December 20, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants