Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge main into releases/v2 #1659

Merged
merged 6 commits into from
Apr 26, 2023
Merged

Merge main into releases/v2 #1659

merged 6 commits into from
Apr 26, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 26, 2023 •
edited by angelapwen
Loading

Merging da583b0 into releases/v2.

Conductor for this PR is @angelapwen.

Contains the following pull requests:

Please do the following:

  • Ensure the CHANGELOG displays the correct version and date.
  • Ensure the CHANGELOG includes all relevant, user-facing changes since the last release.
  • Check that there are not any unexpected commits being merged into the releases/v2 branch.
  • Ensure the docs team is aware of any documentation changes that need to be released.
  • Approve and merge this PR. Make sure Create a merge commit is selected rather than Squash and merge or Rebase and merge.
  • Merge the mergeback PR that will automatically be created once this PR is merged.

github-actions[bot] and others added 6 commits April 21, 2023 19:09
Update changelog and version after v2.3.0
0f085f9
Update checked-in dependencies
90f0532
@cklin
Merge pull request #1656 from github/mergeback/v2.3.0-to-main-b2c19fb9
c5f3f01 
Mergeback v2.3.0 refs/heads/releases/v2 into main
@angelapwen
Throw full error for CLI bundle download (#1657)
a9648ea
@angelapwen
Add workload_run_attempt to analysis upload (#1658)
da583b0 
* Refactor status report upload logic

Previously we had duplicated the logic to check `GITHUB_RUN_ID`. We now call the `getWorkflowRunID()` method for the status report upload method, and move the logic for the run attempt to `getWorkflowRunAttempt()`

* Add `workflow_run_attempt` to analysis payload

* Stop allowing `undefined` run IDs and attempts

Because we already throw an error if the ID or attempt aren't numbers, we don't have to allow `undefined` values into the payload.
Update changelog for v2.3.1
1f2f707
@angelapwen angelapwen marked this pull request as ready for review April 26, 2023 20:17
@angelapwen angelapwen requested a review from a team as a code owner April 26, 2023 20:17
@angelapwen angelapwen merged commit 8662eab into releases/v2 Apr 26, 2023
@angelapwen angelapwen deleted the update-v2.3.1-da583b07a branch April 26, 2023 20:42
@snyk-bot snyk-bot mentioned this pull request Apr 27, 2023
Open
This was referenced Apr 27, 2023
Open
Open
This was referenced Jun 21, 2023
Open
Open
Open
Open
Open
This was referenced Nov 29, 2023
Open
Open
@aliscco aliscco mentioned this pull request Apr 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelapwen angelapwen angelapwen approved these changes

Assignees

@angelapwen angelapwen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@angelapwen @cklin