Telemetry: send event report times as ISO strings #1751
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found in the debug logs of my test run of the new
event_report
fields that the request was malformed due to thestarted_at
andcompleted_at
timestamps being sent as strings rather than ISO strings. There was no impact to any users as the feature flag this change was behind was off for all actors.This change simply updates the timestamps so that they are sent with the appropriate type.
This time I have validated with test runs (links internally only): run 1, run 2 with debug logging and confirmed that I did not get an API error.
I also ran the query @esbena ran on the data warehouse and confirmed that we get 2
event_report
s with length 1.Merge / deployment checklist