Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VSCode settings: set default formatter for TS #1975

Merged
merged 1 commit into from
Oct 30, 2023
Merged

VSCode settings: set default formatter for TS #1975

merged 1 commit into from
Oct 30, 2023

Conversation

nickrolfe
Copy link
Contributor

@nickrolfe nickrolfe commented Oct 27, 2023 •
edited by angelapwen
Loading

Tell VSCode to format TypeScript code with Prettier, since that's the same tool we use to check the format with npm run lint.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@nickrolfe
VSCode settings: set default formatter for TS
88d03c6 
Tell VSCode to format code with Prettier, since that's the same tool we
use to check the format with `npm run lint`.
@nickrolfe nickrolfe requested a review from a team as a code owner October 27, 2023 16:22
angelapwen
angelapwen approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ✨

@nickrolfe nickrolfe merged commit df32e39 into main Oct 30, 2023
337 checks passed
@nickrolfe nickrolfe deleted the nickrolfe/vscode-formatter branch October 30, 2023 10:49
@github-actions github-actions bot mentioned this pull request Nov 14, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelapwen angelapwen angelapwen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickrolfe @angelapwen