Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the action stub #2571

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Add the action stub #2571

merged 2 commits into from
Oct 29, 2024

Conversation

aeisenberg
Copy link
Contributor

This is required for the migration of the codeql-action to an immutable action.

We can delete this after the migration is done, or just keep it so people have an extra way to understand how to use the action.

Merge / deployment checklist

  • [n/a] Confirm this change is backwards compatible with existing workflows.
  • [n/a] Confirm the readme has been updated if necessary.
  • [n/a] Confirm the changelog has been updated if necessary.

@aeisenberg
Add the action stub
a883cff 
This is required for the migration of the codeql-action to an
immutable action.

We can delete this after the migration is done, or just keep it
so people have an extra way to understand how to use the action.
@aeisenberg aeisenberg marked this pull request as ready for review October 29, 2024 16:28
@aeisenberg aeisenberg requested a review from a team as a code owner October 29, 2024 16:28
henrymercer
henrymercer previously approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we run the tool before on repos containing multiple Actions? If not, it might be worth doing a dry run on a fork.

action.yml Outdated Show resolved Hide resolved
@aeisenberg
Copy link
Contributor Author

Have we run the tool before on repos containing multiple Actions? If not, it might be worth doing a dry run on a fork.

@Jcambass has already mentioned this should not be a problem.

@aeisenberg @henrymercer
Update action.yml
6554251 
Co-authored-by: Henry Mercer <[email protected]>
@aeisenberg aeisenberg merged commit 19484c7 into main Oct 29, 2024
275 checks passed
@aeisenberg aeisenberg deleted the aeisenberg/action-stub branch October 29, 2024 21:35
This was referenced Nov 8, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrymercer henrymercer henrymercer approved these changes

@Jcambass Jcambass Awaiting requested review from Jcambass

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aeisenberg @henrymercer