Michaelrfairhurst/fix autosar a1 1 2 detect -w flag test workaround #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gcc may be compiled to auto include warnings such as -Wformat. However, passing in `-w` will suppress the enabled format warnings. The previous query would not raise an issue, as it saw the `-Wformat` flag etc, even though if `-w` was present, causing gcc to run with no warnings enabled.
|
Confirmed that this passes gcc and clang matrix testing. Both of the following commands: pwsh scripts/matrix_testing/CreateMatrixTestReport.ps1 -Configuration gcc -Rule -RuleName "A1-1-2"
# and
pwsh scripts/matrix_testing/CreateMatrixTestReport.ps1 -Configuration clang -Rule -RuleName "A1-1-2"produce the following csv: (note that the four rows correspond to the directories |
|
@lcartey What do you think? This seems like technical debt, albeit a working solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This draft PR is a copy of #688, demonstrating a possible workaround to pass unit tests and matrix tests with the correct behavior around the
-wflag.