Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LGTM.com - false positive #4239

Closed
Trott opened this issue Sep 9, 2020 · 1 comment
Closed

LGTM.com - false positive #4239

Trott opened this issue Sep 9, 2020 · 1 comment
Labels
false-positive Python

Comments

@Trott
Copy link

Trott commented Sep 9, 2020

Description of the false positive

Left hand side of assignment contains 4 variables, but right hand side is a tuple of length 0.

The tuple is not of length 0. It is of length 4. It is constructed dynamically with += and I'm guessing codeql is missing that.

URL to the alert on the project page on LGTM.com

https://lgtm.com/projects/g/nodejs/node/snapshot/e10efc51c683c1778e22d0f79be18071773803b1/files/configure.py#xf4643e1de1c2c4fc:1
@RasmusWL
Copy link
Member

Hi @Trott, thanks for reporting this 👍 I agree that this is clearly a false positive.

We're currently busy reworking large parts of the Python QL libraries, so I can't make any promises on when we'll be able to look into solving this one, but we'll keep it in our backlog 😊

RasmusWL added a commit to RasmusWL/codeql that referenced this issue Sep 10, 2020
@RasmusWL
Python: Add dataflow tests for dynamic tuple creation
949b81b 
Inspired by the FP-report in github#4239
@RasmusWL RasmusWL mentioned this issue Sep 10, 2020
Merged
@Trott Trott mentioned this issue Jan 16, 2021
Closed
@Trott Trott closed this as completed Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
false-positive Python
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Trott @RasmusWL @MathiasVP