Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go: Add tests for model inheritance #17505

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Go: Add tests for model inheritance #17505

wants to merge 1 commit into from
+621 −0

Conversation

owen-mc
Copy link
Contributor

@owen-mc owen-mc commented Sep 18, 2024 •
edited
Loading

These tests show several things:

  1. That the common use of getACall() in QL models is overly broad: see from ql_models_struct.expected that by modeling S1 we also match calls to I1, which is an interface that S1 implements.
  2. That the subtypes column of MaD has no effect for non-interface methods.
  3. That the subtypes column of MaD has perhaps too much effect for interface methods. Actually it does make sense now that I think about it.

@owen-mc owen-mc added the no-change-note-required This PR does not need a change note label Sep 18, 2024
@owen-mc owen-mc requested a review from a team as a code owner September 18, 2024 11:29
@github-actions github-actions bot added the Go label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Go no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@owen-mc