Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go: Run CI when shared libraries change #17515

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

owen-mc
Copy link
Contributor

@owen-mc owen-mc commented Sep 19, 2024

Go CI should have run for #17504. Hopefully this change will fix it.

I did consider whether to restrict to the shared libraries that are actually used by Go, but I think we will forget to update it.

@owen-mc owen-mc requested a review from a team as a code owner September 19, 2024 10:34
@owen-mc owen-mc added the no-change-note-required This PR does not need a change note label Sep 19, 2024
@owen-mc owen-mc force-pushed the go/run-ci-when-shared-libs-change branch from 9d74b22 to f2fbe64 Compare September 19, 2024 10:45
Copy link
Member

@mbg mbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@owen-mc owen-mc merged commit 682f08c into github:main Sep 19, 2024
12 checks passed
@owen-mc owen-mc deleted the go/run-ci-when-shared-libs-change branch September 19, 2024 13:28
@owen-mc
Copy link
Contributor Author

owen-mc commented Sep 19, 2024

Confirmed that this worked in #17522.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants