Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shared: Do not use @kind graph for CFG test output #17520

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Shared: Do not use @kind graph for CFG test output #17520

merged 1 commit into from
Sep 20, 2024
+9,891 −29,370

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Sep 19, 2024 •
edited
Loading

The original motivation for using @kind graph was to be able to visualize CFGs in VS Code. However, now that we have View CFG, this is no longer needed. Moreover, @kind graph often has spurious reorderings of the output, and there are some known limitations (such as missing multi-edges, IIRC), so it is not well suited for qltest.

@github-actions github-actions bot added C# Ruby Rust Pull requests that update Rust code Swift labels Sep 19, 2024
@hvitved hvitved mentioned this pull request Sep 19, 2024
Merged
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Sep 19, 2024
@hvitved hvitved marked this pull request as ready for review September 19, 2024 17:54
@hvitved hvitved requested review from a team as code owners September 19, 2024 17:54
michaelnebel
michaelnebel approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@michaelnebel michaelnebel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C# LGTM!

redsun82
redsun82 approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@redsun82 redsun82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, thanks for jumping on that!

The only comment I have is that the expected files remain somewhat hard to check for a human (more or less as before). But small diffs (as will usually be the case in a PR) are probably manageable.

@hvitved hvitved merged commit f2e943f into github:main Sep 20, 2024
55 checks passed
@hvitved hvitved deleted the cfg/no-kind-graph branch September 20, 2024 08:10
@hvitved
Copy link
Contributor Author

hvitved commented Sep 20, 2024

The only comment I have is that the expected files remain somewhat hard to check for a human (more or less as before). But small diffs (as will usually be the case in a PR) are probably manageable.

Diffs are, IMO, easier to check in the non-@kind graph format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redsun82 redsun82 redsun82 approved these changes

@michaelnebel michaelnebel michaelnebel approved these changes

Assignees
No one assigned
Labels
C# no-change-note-required This PR does not need a change note Ruby Rust Pull requests that update Rust code Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hvitved @redsun82 @michaelnebel