Codegen: allow full annotation of classes #17530
Merged
+219
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aibaars
reviewed
Sep 20, 2024
| @@ -774,6 +775,63 @@ class _: | |||
| } | |||
|
|
|||
|
|
|||
| def test_annotate_fields(): | |||
| @load | |||
There was a problem hiding this comment.
Adding additional annotation to a class doesn't seem to work yet. I tried:
@annotate(LetExpr)
@rust.doc_test_signature("(maybe_some: Option<String>) -> ()")
class _:but the tests still ends up with a () -> () signature.
There was a problem hiding this comment.
yep, I initially forgot that, fixed now 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to fully reannotate classes with the
@annotatedecoration. Properties can be modified by adding property modifiers to the special_placeholder. Property modifiers can also be undone with~. See unit tests for example (defsnamespacing is only used in tests).