Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note for multi lines output paramater in ga. #24040

Conversation

fabienfoerster
Copy link

@fabienfoerster fabienfoerster commented Feb 20, 2023

Why:

Closes #21529 and continue the work of #21599 by taking into account the comment by @cmwilson21 #21599 (comment)

What's being changed (if available, include any code snippets, screenshots, or gifs):

Add a Note at the end of the Setting an output parameter that clarifies the possibility of writing a multi line output parameter.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@welcome
Copy link

welcome bot commented Feb 20, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 20, 2023
@github-actions
Copy link
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/using-workflows/workflow-commands-for-github-actions.md fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae
fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

@fabienfoerster Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Feb 21, 2023
@cmwilson21
Copy link
Contributor

@fabienfoerster Thanks again for submitting a PR! However, we have another PR with a fix for this issue that we are reviewing. I'm going to go ahead and close this but will reopen if we end up not accepting the other PR. 💛

We'd love another submission from you, so please take a look at our help wanted section to find open issues you can work on, if you are interested.

Thank you for your interest in improving GitHub Docs! 💖

@cmwilson21 cmwilson21 closed this Feb 21, 2023
@fabienfoerster
Copy link
Author

@cmwilson21 my bad, didn't see the other PR. Thanks for the quick feedback. I'll be sure to check the help wanted section and be more rigorous before opening an other PR.

@cmwilson21
Copy link
Contributor

@fabienfoerster No problem at all! It's easy to overlook. 😄

@fabienfoerster
Copy link
Author

@cmwilson21 Hello, it's me again 😄 It's seems that the other PR is not responding since the 5th of January. Can I maybe take over on the issue ?

@cmwilson21
Copy link
Contributor

@fabienfoerster Thanks for checking in! The automations for that other PR did not bump it in my notifications so it had slipped through.

I'm going to go ahead and merge the other PR as it has already received a writer review. The bit we were waiting on was the addition of an example from this comment on the issue. Is that a piece you'd be up for adding?

I'm going to merge the content change but let me know if you can do the example. ✨

@fabienfoerster
Copy link
Author

@cmwilson21 Yes I can do the example when the other PR is merge.

@cmwilson21
Copy link
Contributor

@fabienfoerster Thank you! I've queued the PR, so it should be merged in the next 15-20 minutes or so. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify how multiline output values can be set via GITHUB_OUTPUT
2 participants