Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify case sensitive search #34975

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Clarify case sensitive search #34975

merged 3 commits into from
Oct 17, 2024

Conversation

victorlin
Copy link
Contributor

@victorlin victorlin commented Oct 17, 2024 •
edited
Loading

Why:

The previous text was inaccurate – it is possible to do case sensitive searches with regular expressions.

Closes: #34933

What's being changed (if available, include any code snippets, screenshots, or gifs):

The section on Case Sensitivity

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

  • For content changes, I have completed the self-review checklist.

@victorlin
Clarify case sensitive search
bf30db8 
The previous text was inaccurate – it is possible to do case sensitive
searches with regular expressions.
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 17, 2024 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
search-github/github-code-search/understanding-github-code-search-syntax.md fpt
ghec
 fpt
ghec

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@victorlin
Note that case insensitivity is the default
f63fea4 
Saying "code search is case-insensitive" then saying "you can do
case-sensitive searches" can seem confusing. Make it less confusing by
noting that case insensitivity is only the default behavior.
@nguyenalex836
Copy link
Contributor

@victorlin Hello! 👋 Your changes look great! Would you want to move this PR out of a draft state? We can go ahead and get this merged once that's complete 💛

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team search-github Related to GitHub search and removed triage Do not begin working on this issue until triaged by the team labels Oct 17, 2024
@victorlin
Copy link
Contributor Author

@nguyenalex836 thanks for reviewing! I just confirmed the preview looks like what I'm expecting.

@victorlin victorlin marked this pull request as ready for review October 17, 2024 17:51
@nguyenalex836
Copy link
Contributor

@victorlin Ah awesome! Will get this merged now 💛

@nguyenalex836 nguyenalex836 added this pull request to the merge queue Oct 17, 2024
Merged via the queue into github:main with commit bfaa324 Oct 17, 2024
45 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@victorlin victorlin deleted the update-code-search branch October 17, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguyenalex836 nguyenalex836 nguyenalex836 approved these changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team search-github Related to GitHub search
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add documentation for case-sensitive code search / regex mode modifiers
2 participants
@victorlin @nguyenalex836