Skip to content
This repository has been archived by the owner on Aug 3, 2020. It is now read-only.

Add EventListener interface support #13

Merged
merged 1 commit into from
May 7, 2019
Merged

Add EventListener interface support #13

merged 1 commit into from
May 7, 2019

Conversation

javan
Copy link
Contributor

@javan javan commented May 3, 2019

@javan javan mentioned this pull request May 3, 2019
Merged
5 tasks
@muan muan requested a review from a team May 3, 2019 16:29
@dgraham dgraham requested a review from keithamus May 6, 2019 15:58
keithamus
keithamus reviewed May 6, 2019
View reviewed changes
Copy link
Member

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this @javan! I agree we should definitely get this fixed, but I've left a comment to ensure we fix it in a way which is most compatible with existing browser behaviour. If you could take a look at the review comment, and perhaps add some tests to verify that, then I'll happily merge this in and cut a new patch release!

src/index.js Outdated Show resolved Hide resolved
@keithamus keithamus merged commit 6ea02e7 into github:master May 7, 2019
@keithamus
Copy link
Member

@javan I've released this as 1.0.5 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@keithamus keithamus keithamus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no support for handleEvent
2 participants
@javan @keithamus