Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump actions/upload-artifact from 3 to 4 #1193

Closed
wants to merge 5 commits into from
Closed

Bump actions/upload-artifact from 3 to 4 #1193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e53ed2a
Bump actions/upload-artifact from 3 to 4
dependabot[bot] Sep 11, 2024
b66523c
Merge branch 'main' into dependabot/github_actions/actions/upload-art…
begonaguereca Sep 23, 2024
3073ae4
Merge branch 'main' into dependabot/github_actions/actions/upload-art…
begonaguereca Sep 23, 2024
ac47afc
Merge branch 'main' into dependabot/github_actions/actions/upload-art…
begonaguereca Sep 24, 2024
b372eb0
Try to fix CI by adding dist folder
begonaguereca Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,15 +63,15 @@ jobs:
# This is used by the subsequent publish-test-results.yml
- name: Upload Unit Test Results
if: always() && matrix.runner-os == 'ubuntu-latest'
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: Unit Test Results
path: src/OctoshiftCLI.Tests/unit-tests.xml

# This is used by the subsequent publish-test-results.yml
- name: Upload Code Coverage Report
if: always() && matrix.runner-os == 'ubuntu-latest'
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: Code Coverage Report
path: code-coverage-results.md
Expand All @@ -85,7 +85,7 @@ jobs:
steps:
# This is used by the subsequent publish-test-results.yaml
- name: Upload Event File
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: Event File
path: ${{ github.event_path }}
Expand Down Expand Up @@ -130,7 +130,7 @@ jobs:
SKIP_LINUX: "true"

- name: Upload Binaries
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: binaries-${{ matrix.target-os }}
path: |
Expand Down Expand Up @@ -161,6 +161,9 @@ jobs:
uses: actions/setup-dotnet@v2
with:
global-json-file: global.json

- name: Create dist directory
run: mkdir -p ./dist

- name: Download Binaries
uses: actions/download-artifact@v3
Expand Down Expand Up @@ -260,7 +263,7 @@ jobs:
comment_mode: off

- name: Upload test logs
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: always()
with:
name: integration-test-logs-${{ matrix.source-vcs }}-${{ matrix.runner-os }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/integration-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
SKIP_LINUX: "true"

- name: Upload Binaries
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: binaries-${{ matrix.target-os }}
path: |
Expand Down Expand Up @@ -187,7 +187,7 @@ jobs:
commit: ${{ env.PR_SHA }}

- name: Upload test logs
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: always()
with:
name: integration-test-logs-${{ matrix.source-vcs }}-${{ matrix.runner-os }}
Expand Down
Loading