Add unit tests for GithubClient

[ArinGhazarian]

Closes #173

This PR adds unit tests for the GithubClient class.

• Did you write/update appropriate tests
• Release notes updated (if appropriate)
• Appropriate logging output
• Issue linked

[github-actions]

Test Results

  1 files  ±  0    1 suites  ±0   0s ⏱️ ±0s
89 tests +28  89 ✔️ +28  0 💤 ±0  0 ❌ ±0 

Results for commit 8135e7c. ± Comparison against base commit 9bc1b26.

♻️ This comment has been updated with latest results.

[dylan-smith]

you can't use the new namespace with no-braces syntax yet, codeql doesn't support it.

[ArinGhazarian]

you can't use the new namespace with no-braces syntax yet, codeql doesn't support it.

Yeah totally missed that 😞

[github-actions]

Package	Line Rate	Branch Rate	Complexity	Health
octoshift	62%	54%	372	➖
Summary	62% (1091 / 1753)	54% (144 / 268)	372	➖

[dylan-smith]

you can't use the new namespace with no-braces syntax yet, codeql doesn't support it.

Yeah totally missed that 😞

really sucks, as it stands today we have to choose between being able to use CodeQL or using C# 10 features. My thought is we can live without C# 10 for a while...but how long do we wait. CodeQL team seems to be targetting CY2022Q1 for it.

[ArinGhazarian]

you can't use the new namespace with no-braces syntax yet, codeql doesn't support it.

Yeah totally missed that 😞

really sucks, as it stands today we have to choose between being able to use CodeQL or using C# 10 features. My thought is we can live without C# 10 for a while...but how long do we wait. CodeQL team seems to be targetting CY2022Q1 for it.

Well, also in that regard, apparently implicit typing of Func and Action delegates is a C# 10 feature and not supported by CodeQL yet :(

[dylan-smith]

this all looks great!