Automatically build and release the CLI for the windows-386 build target
#797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arget This updates our release process to build each of our CLIs for x86 Windows devices (i.e. just about anything that isn't x64 or ARM!). At this time, we don't have a way to test that these binaries work as part of our CI/CD process. Nevertheless, we think it's better to distribute a binary that should work than to offer nothing to users who want x86 support! If people run into any problems, they can create an issue and we will, of course, look into it. Fixes #796.
dylan-smith
approved these changes
Feb 2, 2023
|
@dylan-smith I'm seeing the Windows integration test fail - I guess I've broken something! - but looking at the test output, I can't find the line that is actually failing. I can just see that the exit code is wrong. Could you take a look for me? Pretty sure I'm just being stupid... 😓 |
|
|
Ignore me! It passed with another try. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates our release process to build each of our CLIs for x86 Windows devices (i.e. just about anything that isn't x64 or ARM!).
At this time, we don't have a way to test that these binaries work as part of our CI/CD process. Nevertheless, we think it's better to distribute a binary that should work than to offer nothing to users who want x86 support! If people run into any problems, they can create an issue and we will, of course, look into it.
Fixes #796.