Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compound pk tests #387

Merged
merged 13 commits into from
Jul 6, 2022
Merged

compound pk tests #387

merged 13 commits into from
Jul 6, 2022

Conversation

shlomi-noach
Copy link
Contributor

Adding a couple interesting tests:

  • a compound PRIMARY KEY on int auto_increment, varchar
  • a compound PRIMARY KEY on int auto_increment, timestamp

test script improves visibility on checksum failure.

@timvaillancourt timvaillancourt added this to the v1.1.1 milestone Aug 24, 2020
@timvaillancourt timvaillancourt modified the milestones: v1.1.1, v1.2.0 May 3, 2021
@timvaillancourt timvaillancourt modified the milestones: v1.1.2, v1.2.0, v1.1.3 Jun 17, 2021
@timvaillancourt timvaillancourt self-requested a review June 28, 2022 22:36
@timvaillancourt timvaillancourt merged commit cc38a17 into master Jul 6, 2022
@timvaillancourt timvaillancourt deleted the compound-pk-tests branch July 6, 2022 21:22
dm-2 pushed a commit that referenced this pull request Jul 7, 2022
* compound pk tests

* more details in failure diff

* more elaborate test; the pk-ts one consistently fails

* Fix merge conflict

Co-authored-by: Shlomi Noach <[email protected]>
Co-authored-by: Tim Vaillancourt <[email protected]>
Co-authored-by: Tim Vaillancourt <[email protected]>
@dm-2 dm-2 mentioned this pull request Jul 7, 2022
dm-2 pushed a commit that referenced this pull request Jul 7, 2022
* compound pk tests

* more details in failure diff

* more elaborate test; the pk-ts one consistently fails

* Fix merge conflict

Co-authored-by: Shlomi Noach <[email protected]>
Co-authored-by: Tim Vaillancourt <[email protected]>
Co-authored-by: Tim Vaillancourt <[email protected]>
RainbowDashy pushed a commit to RainbowDashy/gh-ost that referenced this pull request Jul 11, 2022
* compound pk tests

* more details in failure diff

* more elaborate test; the pk-ts one consistently fails

* Fix merge conflict

Co-authored-by: Shlomi Noach <[email protected]>
Co-authored-by: Tim Vaillancourt <[email protected]>
Co-authored-by: Tim Vaillancourt <[email protected]>
d-bytebase pushed a commit to bytebase/gh-ost that referenced this pull request Jul 13, 2022
* Merge pull request github#1143 from github/codeql-run-on-prs

Run CodeQL analysis on PRs

* Merge pull request github#1141 from shaohk/fix-two-phase-commit-lost-data_v2

fix(lost data in mysql two-phase commit): lost data in mysql two-phas…

* compound pk tests (github#387)

* compound pk tests

* more details in failure diff

* more elaborate test; the pk-ts one consistently fails

* Fix merge conflict

Co-authored-by: Shlomi Noach <[email protected]>
Co-authored-by: Tim Vaillancourt <[email protected]>
Co-authored-by: Tim Vaillancourt <[email protected]>

* Use `switch` statements for readability, simplify `.NewGoMySQLReader()` (github#1135)

* Use `switch` statements for readability

* Simplify initBinlogReader()

* Add context/timeout to HTTP throttle check (github#1131)

* Add context/timeout to HTTP throttle check

* Dont run `.GetThrottleHTTPInterval()` on every loop

* Update help message

* Var rename

* 2022

* Add timeout flag

* Add unix/tcp server commands, use ParseInt() for string->int64

* Var rename

* Re-check http timeout on every loop iteration

* Remove stale comment

* Make throttle interval idempotent

* var rename

* Usage grammar

* Make http timeout idempotent too

* Parse time.Duration once

* Move timeout to NewThrottler

* Help update

* Set User-Agent header

* Re-add newline

Co-authored-by: dm-2 <[email protected]>

* Default to `go1.17.11` (github#1136)

* Default to go1.17.11

* `go mod vendor`

Co-authored-by: dm-2 <[email protected]>

* Cancel any row count queries before attempting to cut over (github#846)

* Cancel any row count queries before attempting to cut over

Closes github#830. Switches from using `QueryRow` to `QueryRowContext`, and
stores a context.CancelFunc in the migration context, which is called to
halt any running row count query before beginning the cut over.

* Make it threadsafe

* Kill the count query on the database side as well

* Explicitly grab a connection to run the count, store its connection id
* When the query context is canceled, run a `KILL QUERY ?` on that connection id

* Rewrite these to use the threadsafe functions, stop exporting the cancel func

* Update logger

* Update logger

Co-authored-by: Tim Vaillancourt <[email protected]>
Co-authored-by: Tim Vaillancourt <[email protected]>
Co-authored-by: dm-2 <[email protected]>

Co-authored-by: dm-2 <[email protected]>
Co-authored-by: Shlomi Noach <[email protected]>
Co-authored-by: Shlomi Noach <[email protected]>
Co-authored-by: Tim Vaillancourt <[email protected]>
Co-authored-by: Tim Vaillancourt <[email protected]>
Co-authored-by: Andrew Mason <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants