*bugfix) uncomment the install script. #81
Conversation
Make more consistency to the description in README. I spend not a few time to know this thing, while following the README to finish my job.
| # config.vm.provision "shell", inline: "apt-get update; exec env /vagrant_data/script/install-openldap" | ||
| # If install the openldap with apt-get failed, you can comment this line. | ||
| config.vm.provision "shell", inline: "apt-get update; exec env /vagrant_data/script/install-openldap" | ||
|
|
||
| config.vm.provision "shell", inline: 'echo "HIIIIIII"', run: "always" |
There was a problem hiding this comment.
I think line 17 was added by mistake: we should remove this line as well.
There was a problem hiding this comment.
Err, that's line 19 (the echo "HIIIIII" line).
|
Thanks for opening up this PR! Happy to merge this in, just want to clean up the unneeded line! |
|
@mtodd Hear you are, bro~ |
|
@wuranbo build is red, probably because it needs master merged in. Doesn't seem related to the diff. |
Make more consistency to the description in README. I spend not a few time to know this thing, while following the README to finish my job.
|
@mtodd I tried to rebase impertinently. But it turns out that it's not the reason. So I check the two CI failure, https://travis-ci.org/github/github-ldap/builds/65865839, https://travis-ci.org/github/github-ldap/builds/65998284。 The reason of this two failure were the CI env.Travis CI run apt-get update failed. Err http://us.archive.ubuntu.com/ubuntu/ precise-updates/main slapd amd64 2.4.28-1.1ubuntu4.4 |
Make more consistency to the description in README.
I spend not a few time to know this thing, while following the README to finish my job.