Exclude Directory.Build.rsp from VisualStudio.gitignore template #4493
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Directory.Build.rsp` is a [documented file][1] that allows setting default arguments to command line builds. However, our .gitignore template ignores _all_ `*.rsp` files. which causes confusion: 1. Devs write an .rsp file and if they aren't being attentive forget to commit it 2. Adding it to git requires `git add --force`, which some devs mistake for a destructive or not-recommended action Thus, explicitly allow the `Directory.Build.rsp` file. [1]: https://learn.microsoft.com/en-us/visualstudio/msbuild/msbuild-response-files?view=vs-2022#directorybuildrsp
|
@dooleydevin, sorry for the bother, but at the most recently active person in this repo, would you mind letting me know what I can do to push this change forward? Any help is greatly appreciated. Thanks! |
|
@MattKotsenas this looks like a good change to me based on this quote from the docs:
Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change:
Directory.Build.rspis a documented file that allows setting default arguments to command line builds. However, the .gitignore template ignores all*.rspfiles. which causes confusion:git add --force, which some devs mistake for a destructive or not-recommended actionThus, explicitly allow the
Directory.Build.rspfile.Links to documentation supporting these rule changes: