Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor misspell fixes #101

Closed
wants to merge 5 commits into from
Closed

Minor misspell fixes #101

wants to merge 5 commits into from

Conversation

@MikeMcQuaid
Copy link
Contributor

Awesome, thanks! Can you make the issue body a list of checkboxes and check them off as they are merged upstream?

@hiveminded
Copy link
Author

@MikeMcQuaid You're welcome! Could you review the body again, please? You have the permission to change the body if it's not ok yet.

@MikeMcQuaid
Copy link
Contributor

@hiveminded That's great, thanks! Give me a shout when they are all merged 👍

@hiveminded
Copy link
Author

@MikeMcQuaid I can agree but I think that you don't have to depend on an external author to apply these fixes. I have fixed the misspells to this repository too for this purpose, third-party authors may login to github after 2 years, we will wait so long?

@MikeMcQuaid
Copy link
Contributor

@hiveminded Given none of these changes are user visible I think it's worth waiting for upstream. Otherwise if we update these npm modules the problems will return again. Sorry!

@hiveminded
Copy link
Author

@MikeMcQuaid No need to sorry I had that answer in mind too, I understand. Let's wait then :)

@MikeMcQuaid
Copy link
Contributor

@hiveminded Thanks for the issue and PRs but closing this for now.

@hiveminded
Copy link
Author

Alright, no worries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants