-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor misspell fixes #101
Minor misspell fixes #101
Conversation
Relative: pellepim/jstimezonedetect#2
Relative: primer/primer-alerts#1
Awesome, thanks! Can you make the issue body a list of checkboxes and check them off as they are merged upstream? |
@MikeMcQuaid You're welcome! Could you review the body again, please? You have the permission to change the body if it's not ok yet. |
@hiveminded That's great, thanks! Give me a shout when they are all merged 👍 |
@MikeMcQuaid I can agree but I think that you don't have to depend on an external author to apply these fixes. I have fixed the misspells to this repository too for this purpose, third-party authors may login to github after 2 years, we will wait so long? |
@hiveminded Given none of these changes are user visible I think it's worth waiting for upstream. Otherwise if we update these |
@MikeMcQuaid No need to sorry I had that answer in mind too, I understand. Let's wait then :) |
@hiveminded Thanks for the issue and PRs but closing this for now. |
Alright, no worries! |
Files changed:
Relative PRs to the external repositories:
Checked: upstream merged
Unchecked: upstream, not yet merged