Merge pull request #259 from ridiculous/ridiculous-patch-1

Fix bug with marshalling experiments
github · Jun 17, 2024 · 987f8be · 987f8be
2 parents fcb5050 + 2c4c6e9
commit 987f8be
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/lib/scientist/experiment.rb b/lib/scientist/experiment.rb
@@ -345,7 +345,7 @@ def marshal_dump
     [@name, @result, @raise_on_mismatches]
   end
 
-  def marshal_load
+  def marshal_load(array)
     @name, @result, @raise_on_mismatches = array
   end
 end
diff --git a/test/scientist/experiment_test.rb b/test/scientist/experiment_test.rb
@@ -512,6 +512,10 @@ def @ex.raised(op, exception)
       assert_kind_of(String, Marshal.dump(mismatch))
     end
 
+    it "can be marshal loaded" do
+      assert_kind_of(Fake, Marshal.load(Marshal.dump(@ex)))
+    end
+
     describe "#raise_on_mismatches?" do
       it "raises when there is a mismatch if the experiment instance's raise on mismatches is enabled" do
         Fake.raise_on_mismatches = false