Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the flow to continue after user needed to connect an integration (#3621) #3750

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

sergeibbb
Copy link
Member

@sergeibbb sergeibbb commented Nov 14, 2024

The problem

When I go through connect an integration flow, it’s not finished automatically. I need to click start work again and start from the begining

My testing

Pre. steps:

  • disconnect Jira on GK-dev
  • disconnect GitHub integration in GitLens

Flow when user connects something:

  • Open Start Work. Select "create from issue"
  • Click "Connect". Pass through the flow on the website.
  • Get back to GitLens
  • Expected result: You continue with issues.

Flow when user doesn't connect anything:

  • Open Start Work. Select "create from issue"
  • Click "Connect". Pass through the flow on the website.
  • Right before getting back to GitLens open the GK-dev settings in another browser tab
  • Disconnect GitHub there.
  • Get back to the "connect flow" browser tab and from there get back to GitLens
  • Expected result:
    • the quickpick stays on the "Connect" step
    • the loader of the step stops until you click the item again.

@sergeibbb sergeibbb force-pushed the bug/3621-fix-connect-integration branch from ac59313 to c9cf41a Compare November 14, 2024 13:34
@sergeibbb sergeibbb linked an issue Nov 14, 2024 that may be closed by this pull request
@sergeibbb sergeibbb added the bug Something isn't working label Nov 14, 2024
@sergeibbb sergeibbb added this to the 16.0 milestone Nov 14, 2024
@axosoft-ramint
Copy link
Contributor

axosoft-ramint commented Nov 14, 2024

@sergeibbb What is the bug being fixed here? Which of the flows posted in the description are not working as expected, and what is happening instead of the expected result?

@sergeibbb
Copy link
Member Author

@axosoft-ramint

When I go through connect an integration flow, it’s not finished automatically. I need to click start work again and start from the begining

@axosoft-ramint axosoft-ramint merged commit 9b88c4c into main Nov 14, 2024
3 checks passed
@axosoft-ramint axosoft-ramint deleted the bug/3621-fix-connect-integration branch November 14, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Start Work operation in Home view
3 participants