Added auto-setting of www-ssl and api-ssl certificates, extra debugging, support for OpenSSH 7+ #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ys, vice DSA. RSA private keys require manual intervention from the user to add a PubkeyAcceptedKeyTypes setting to their SSH config file in OpenSSH 7+ and users may not be aware.
…s well as additional debugging information for the user. Added variables for key phrases that are repeated to cut down on typo options and ease of changing in the future.
…tificates and fixed typo
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is similar to pull request #8 but more comprehensive in the places it fixes "DSA" to be "RSA" in the code examples and commentary. OpenSSH 7+ doesn't allow users to use DSA without manually approving it in their SSH config file and most users will have errors (see the open issues for reference). The README is updated with this fact and it is flagged at the top as a major update.
This pull request also automatically sets the www-ssl and api-ssl certificates to be the newly uploaded one. The README is updated with this fact.
This pull request also changes a lot of the references to files to be variables that are set once. This allows greater flexibility to the end user and lowers the possibility of typos later during changes.