Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ssh-gateway] support rsa sha256/sha512 algorithm #12288

Merged
merged 1 commit into from
Aug 24, 2022
Merged

[ssh-gateway] support rsa sha256/sha512 algorithm #12288

merged 1 commit into from
Aug 24, 2022

Conversation

iQQBot
Copy link
Contributor

@iQQBot iQQBot commented Aug 23, 2022

Description

[ssh-gateway] support rsa sha256/sha512 algorithm

This PR include gitpod-io/golang-crypto#3

Related Issue(s)

Fixes #12287

How to test

  1. use ssh-keygen to generate rsa key pair
  2. upload public key to Gitpod
  3. install openssh 9.0 client in your local machine or workspace
  4. start a new workspace in preview environment
  5. using this private key to connect new workspace via ssh gateway, you can use -vvvv flag to see verbose log, you will see it using rsa-sha2-512

image

image

Release Notes

[ssh-gateway] support rsa sha256/sha512 algorithm

Documentation

Werft options:

  • /werft with-preview

@iQQBot iQQBot requested review from a team August 23, 2022 06:19
@github-actions github-actions bot added team: delivery Issue belongs to the self-hosted team team: workspace Issue belongs to the Workspace team and removed size/S labels Aug 23, 2022
@akosyakov
Copy link
Member

akosyakov commented Aug 23, 2022 •
edited by werft-gitpod-dev-com bot
Loading

@jeanp413 could you help to verify please? 🙏

jeanp413
jeanp413 approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@jeanp413 jeanp413 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works 🚀

@roboquat roboquat merged commit d9dfaee into main Aug 24, 2022
@roboquat roboquat deleted the pd/ssh-rsa branch August 24, 2022 10:09
@roboquat roboquat added the deployed: workspace Workspace team change is running in production label Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanp413 jeanp413 jeanp413 approved these changes

@sagor999 sagor999 sagor999 approved these changes

@mrsimonemms mrsimonemms mrsimonemms approved these changes

Assignees
No one assigned
Labels
deployed: workspace Workspace team change is running in production release-note team: delivery Issue belongs to the self-hosted team team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some Open SSH and RSA key versions are not compatible with Gitpod SSH Gateway
6 participants
@iQQBot @akosyakov @mrsimonemms @sagor999 @jeanp413 @roboquat