Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

align Node.js version with desktop VS Code #2508

Merged
merged 1 commit into from
Dec 14, 2020
Merged

align Node.js version with desktop VS Code #2508

merged 1 commit into from
Dec 14, 2020

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Dec 11, 2020 •
edited
Loading

  • /werft https

What it does

How to test

  • Start a workspace with Theia, install https://open-vsx.org/extension/laike9m/cyberbrain and check that it gets activated without any errors.
  • Do the same for Code. It won't be possible to install this extension, since we have to upgrade Code, but workspace should start and installing other extensions should work.

@akosyakov
fix #2435: align Node.js version with desktop VS Code
77f9c50 
for better compatibility of VS Code extensions
@akosyakov akosyakov mentioned this pull request Dec 11, 2020
Closed
@geropl
Copy link
Member

geropl commented Dec 14, 2020 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-akosyakov-activating-extension-2435.2

geropl
geropl approved these changes Dec 14, 2020
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works as advertised! 👍

@akosyakov akosyakov merged commit 1d8b4a6 into master Dec 14, 2020
@akosyakov akosyakov deleted the akosyakov/activating-extension-2435 branch December 14, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

@AlexTugarev AlexTugarev Awaiting requested review from AlexTugarev

@svenefftinge svenefftinge Awaiting requested review from svenefftinge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Activating extension failed: Must use import to load ES Module
2 participants
@akosyakov @geropl