Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to code 1.53.2 #3225

Merged
merged 1 commit into from
Feb 22, 2021
Merged

upgrade to code 1.53.2 #3225

merged 1 commit into from
Feb 22, 2021

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Feb 18, 2021 •
edited
Loading

What it does

Noteworthy for Gitpod integration:

  • terminals are get proper initial layout now and layout is preserved
  • support permessage-deflate extension for web sockets

Code migration changes: gitpod-io/openvscode-server@7cb02ee

How to test

  • Enable feature preview and Code
  • Language Support should be available, try to edit typescript files
  • it should be possible to install/uninstall extensions
  • Code CLI should work
  • Terminals should be properly opened initially and preserved between page reloads
  • User data should be synched between workspaces

@akosyakov akosyakov force-pushed the akosyakov/upgrade-code-3069 branch 2 times, most recently from fdcc6c8 to 835ae49 Compare February 19, 2021 12:59
@akosyakov akosyakov marked this pull request as ready for review February 19, 2021 14:11
JanKoehnlein
JanKoehnlein approved these changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@JanKoehnlein JanKoehnlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akosyakov akosyakov merged commit 69cb072 into master Feb 22, 2021
@akosyakov akosyakov deleted the akosyakov/upgrade-code-3069 branch February 22, 2021 12:37
@laike9m
Copy link

laike9m commented Feb 23, 2021

Has this change been deployed? I seem to remember there's a way to check the current node.js version used by Gitpod, but I can't find it on the UI anymore.

@akosyakov
Copy link
Member Author

It will be deployed by the end of next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanKoehnlein JanKoehnlein JanKoehnlein approved these changes

@csweichel csweichel Awaiting requested review from csweichel

@svenefftinge svenefftinge Awaiting requested review from svenefftinge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

upgrade Code
3 participants
@akosyakov @laike9m @JanKoehnlein