Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Bs feature branch #557

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

Conversation

bshmu
Copy link

@bshmu bshmu commented Jan 29, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Adds a directory within operators to hold all MutMatrix related logic.

MutMatrix is updated with to_tensor() and from_tensor() methods to call tensor objects methods on the MutMatrix object. Some tensor methods (e.g. reshape, transpose, matmul, reduce_sum) are added to MutMatrix implementation.

Two new traits/impls for MutMatrix are added:

  1. MatrixLinalgTrait: logic for solving 2D systems of equations. Replicates np.linalg.solve().
  2. MatrixStatisticsTrait: mean, weighted mean, covariance, weighted covariance, and exponential weights functions added. Replicates numpy.average() and numpy.covariance().

Tests are added and all imports using MutMatrix (e.g. TreeEnsembleClassifier) are updated accordingly.

Does this introduce a breaking change?

  • Yes
  • No

Copy link
Collaborator

@raphaelDkhn raphaelDkhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bshmu, thanks for your PR!
Some things are missing to make the PR valid.
Please follow this step-by-step tutorial, to see how to implement operators in Orion:
https://orion.gizatech.xyz/academy/tutorials/implement-new-operators-in-orion

@raphaelDkhn raphaelDkhn changed the base branch from main to develop February 9, 2024 13:42
@raphaelDkhn raphaelDkhn changed the title Bs feature branch [WIP] Bs feature branch Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants