Check utf8 relative anchors #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There wasn't a specific test for this, and it fails on some setups. The link in the fixture is a direct copy-paste from one that fails on my project. But the test passes on this test suite... So there is something else going on. Relates to gjtorikian#757
Looking a little deeper into the source code of the failures, I noticed that not _all_ the non-ASCII links were failing, only some of them. The site gets built with relative links between pages, and it was links to another page with a "../page/#hash" syntax which failed. This commit adds a test directory which mimics that structure and reliably reproduces the error... I think!
|
Rad, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test for the false-negative failures seen in #757 - the root cause was an interaction between the (now-removed) regexp in the
clean_url!method and Addressable::URI'snormalize. The test passes now that #820 is merged but the test should prevent regressions in the future.