Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AcceleratedBatchedMeshRaycast: use getVisibleAt instead of drawInfo object #706

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

agargaro
Copy link
Contributor

@agargaro agargaro commented Sep 8, 2024

Two questions:

  1. It's necessary to create a way to get instances in use count (drawInfo.length). Is an instancesCount getter okay?

  2. The method getVisibleAt and property instancesCount (and other future methods) , may not exist if the user is using an older version of three.js. How would you prefer to proceed?

Adding these methods to BatchedMesh.prototype?
Change the minimum version of three.js?

@gkjohnson
Copy link
Owner

It's necessary to create a way to get instances in use count (drawInfo.length). Is an instancesCount getter okay?

I think adding a getter for instanceCount and geometryCount would be good additions to BatchedMesh.

The method getVisibleAt and property instancesCount (and other future methods) , may not exist if the user is using an older version of three.js. How would you prefer to proceed?

We can handle that once they're available. But we can possibly check the version again or wait and then release a new major revision after a few releases, I think.

@gkjohnson
Copy link
Owner

Thanks! I made issue #707 to track the addition of other functions to BatchedMesh.

@gkjohnson gkjohnson merged commit b98edd1 into gkjohnson:master Sep 9, 2024
4 checks passed
@gkjohnson
Copy link
Owner

Just published in version 0.7.7

@agargaro agargaro deleted the getVisibleAtReplace branch September 9, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants